Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Pratik Vyas
* Mike Larkin [2018-10-03 12:19:09 -0700]: How about this? pd, thoughts? This code is just the rate limiter code. Today the code says "have I reached the number of characters output based on my baud rate that indicates I need to pause a bit?". And pausing after 0 characters has been output ma

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Mike Larkin
On Wed, Oct 03, 2018 at 12:19:09PM -0700, Mike Larkin wrote: > On Wed, Oct 03, 2018 at 12:13:05PM -0700, Mike Larkin wrote: > > On Wed, Oct 03, 2018 at 12:06:47PM -0700, Pratik Vyas wrote: > > > * Greg Steuck [2018-10-03 11:40:22 -0700]: > > > > > > > $ egdb /syzkaller/src/usr.sbin/vmd/obj/vmd /v

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Greg Steuck
Thanks Pratik. I reverted my hack and applied your patch instead.

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Mike Larkin
On Wed, Oct 03, 2018 at 12:13:05PM -0700, Mike Larkin wrote: > On Wed, Oct 03, 2018 at 12:06:47PM -0700, Pratik Vyas wrote: > > * Greg Steuck [2018-10-03 11:40:22 -0700]: > > > > > $ egdb /syzkaller/src/usr.sbin/vmd/obj/vmd /var/crash/vmd/38082.core > > > Core was

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Mike Larkin
On Wed, Oct 03, 2018 at 12:06:47PM -0700, Pratik Vyas wrote: > * Greg Steuck [2018-10-03 11:40:22 -0700]: > > > $ egdb /syzkaller/src/usr.sbin/vmd/obj/vmd /var/crash/vmd/38082.core > > Core was generated by `vmd'. > > Program terminated with signal SIGFPE, Arithme

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Pratik Vyas
* Greg Steuck [2018-10-03 11:40:22 -0700]: $ egdb /syzkaller/src/usr.sbin/vmd/obj/vmd /var/crash/vmd/38082.core Core was generated by `vmd'. Program terminated with signal SIGFPE, Arithmetic exception. #0 0x0c07a64174a0 in vcpu_process_com_data (vei=, vm_id

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Greg Steuck
Since I don't understand how com1_dev.pause_ct can be zero, I'll hack around the problem to keep the runs stable: diff --git a/usr.sbin/vmd/ns8250.c b/usr.sbin/vmd/ns8250.c index 74e86a92954..69957e38cce 100644 --- a/usr.sbin/vmd/ns8250.c +++ b/usr.sbin/vmd/ns8250.c @@ -237,7 +237,7 @@ vcpu_proces

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Mike Larkin
On Wed, Oct 03, 2018 at 12:00:07PM -0700, Mike Larkin wrote: > On Wed, Oct 03, 2018 at 11:40:22AM -0700, Greg Steuck wrote: > > $ egdb /syzkaller/src/usr.sbin/vmd/obj/vmd /var/crash/vmd/38082.core > > Core was generated by `vmd'. > > Program terminated with signal

Re: vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Mike Larkin
On Wed, Oct 03, 2018 at 11:40:22AM -0700, Greg Steuck wrote: > $ egdb /syzkaller/src/usr.sbin/vmd/obj/vmd /var/crash/vmd/38082.core > Core was generated by `vmd'. > Program terminated with signal SIGFPE, Arithmetic exception. > #0 0x0c07a64174a0 in vcpu_proces

vmd: division by zero in vcpu_process_com_data

2018-10-03 Thread Greg Steuck
$ egdb /syzkaller/src/usr.sbin/vmd/obj/vmd /var/crash/vmd/38082.core Core was generated by `vmd'. Program terminated with signal SIGFPE, Arithmetic exception. #0 0x0c07a64174a0 in vcpu_process_com_data (vei=, vm_id=, vcpu_id=) at /syzkaller/src/usr.sbin/vm