On Fri, Mar 01, 2019 at 01:37:58PM +0100, Antoine Jacoutot wrote:
> On Fri, Mar 01, 2019 at 01:28:58PM +0100, Klemens Nanni wrote:
> > I blatantly missed the argc/argv adjustments after getopt(3), resulting
> > in valid commands like `vmctl create a -s 1G' to fail.
> >
> > Noticed by ajacoutot the
On Fri, Mar 01, 2019 at 01:28:58PM +0100, Klemens Nanni wrote:
> I blatantly missed the argc/argv adjustments after getopt(3), resulting
> in valid commands like `vmctl create a -s 1G' to fail.
>
> Noticed by ajacoutot the hard way.
>
> OK?
Works for me (tm).
ok :-)
>
> Index: usr.sbin/vmctl/
On Fri, Mar 01 2019, Klemens Nanni wrote:
> I blatantly missed the argc/argv adjustments after getopt(3), resulting
> in valid commands like `vmctl create a -s 1G' to fail.
>
> Noticed by ajacoutot the hard way.
>
> OK?
ok jca@
> Index: usr.sbin/vmctl/main.c
> ===
I blatantly missed the argc/argv adjustments after getopt(3), resulting
in valid commands like `vmctl create a -s 1G' to fail.
Noticed by ajacoutot the hard way.
OK?
Index: usr.sbin/vmctl/main.c
===
RCS file: /cvs/src/usr.sbin/vmctl
On Fri, Mar 01, 2019 at 01:33:48AM +0100, Klemens Nanni wrote:
> tedu's apm(8) diff reminded me that certain vmctl(8) commands are too
> relaxed:
>
> $ vmctl start a b
> vmctl: start vm command failed: Operation not permitted
> $ vmctl stop a b
> stopping vm a: vm not found
tedu's apm(8) diff reminded me that certain vmctl(8) commands are too
relaxed:
$ vmctl start a b
vmctl: start vm command failed: Operation not permitted
$ vmctl stop a b
stopping vm a: vm not found
$ vmctl create a b
could not create a: missing size
