Re: vmctl: improve error message

2018-07-03 Thread Mike Larkin
On Tue, Jul 03, 2018 at 08:59:29AM -0600, Theo de Raadt wrote: > This incorrect codepath occurs in other places also. I think it > ends up using an EINVAL from some other operation. Quite a ways > earlier inside vmmaction(). Which is unrelated to the actual failure. > > The same problem is in v

Re: vmctl: improve error message

2018-07-03 Thread Theo de Raadt
This incorrect codepath occurs in other places also. I think it ends up using an EINVAL from some other operation. Quite a ways earlier inside vmmaction(). Which is unrelated to the actual failure. The same problem is in vm_start_complete() pause_vm_complete() and unpause_vm_complete() use a d

vmctl: improve error message

2018-07-03 Thread Anton Lindqvist
Hi, Stopping a VM owned by root as a non-root user fails with the following error message: $ vmctl stop test vmctl: terminate vm command failed: Invalid argument I think favoring warnc() with the appropriate errno number passed along improves things. This of course is under the assumption tha