Re: uvm_fault: kill goto in uvm_fault()

2020-12-08 Thread Theo Buehler
On Mon, Dec 07, 2020 at 04:08:46PM -0300, Martin Pieuchot wrote: > Diff below rewrites uvm_fault() using a loop. > > I added a KERNEL_LOCK/UNLOCK() dance around the part that won't be > unlocked soon to illustrate where this is going. > > ok? I'm also ok with this. Total bikesheed, but I would

Re: uvm_fault: kill goto in uvm_fault()

2020-12-08 Thread Jonathan Matthew
On Mon, Dec 07, 2020 at 04:08:46PM -0300, Martin Pieuchot wrote: > Diff below rewrites uvm_fault() using a loop. > > I added a KERNEL_LOCK/UNLOCK() dance around the part that won't be > unlocked soon to illustrate where this is going. > > ok? yes, ok jmatthew@ > > Index: uvm/uvm_fault.c >

uvm_fault: kill goto in uvm_fault()

2020-12-07 Thread Martin Pieuchot
Diff below rewrites uvm_fault() using a loop. I added a KERNEL_LOCK/UNLOCK() dance around the part that won't be unlocked soon to illustrate where this is going. ok? Index: uvm/uvm_fault.c === RCS file: /cvs/src/sys/uvm/uvm_fault.c,