Re: use NULL instead of 0 for pointers in sys/net

2021-10-23 Thread Jonathan Gray
On Sun, Oct 24, 2021 at 07:23:30AM +0200, Sebastien Marie wrote: > > ok semarie@ > > and while reviewing the code, I saw sppp_get_ip_addrs() last argument > (u_int32_t *srcmask) is always passed as NULL. > > In fact, both sppp_get_ip_addrs() and sppp_get_ip6_addrs() has the > same argument never

Re: use NULL instead of 0 for pointers in sys/net

2021-10-23 Thread Sebastien Marie
ok semarie@ and while reviewing the code, I saw sppp_get_ip_addrs() last argument (u_int32_t *srcmask) is always passed as NULL. In fact, both sppp_get_ip_addrs() and sppp_get_ip6_addrs() has the same argument never used. Does it is something to simplify ? The code inside the functions is rela

use NULL instead of 0 for pointers in sys/net

2021-10-23 Thread Jonathan Gray
diff --git sys/net/bpf.c sys/net/bpf.c index 87a9d726423..87418c3dc17 100644 --- sys/net/bpf.c +++ sys/net/bpf.c @@ -1019,7 +1019,7 @@ bpf_setf(struct bpf_d *d, struct bpf_program *fp, int wf) KERNEL_ASSERT_LOCKED(); - if (fp->bf_insns == 0) { + if (fp->bf_insns == NULL) {