Re: urndis(4) Frame length validation

2011-03-20 Thread Bryan
On 03/20/11 04:34, Janne Johansson wrote: 2011/3/20 Loganaden Velvindron Hi, this diff also discards packets larger than maximum buffer size. With this patch and doing large scp's, I get a few: urndis0: urndis_decap invalid buffer len 1< minimum header 44 maximum size 1562 urndis0: urndis_

Re: urndis(4) Frame length validation

2011-03-20 Thread Loganaden Velvindron
armani@ pointed out that the checking is already done below, so the diff is useless. //Logan C-x-C-c

Re: urndis(4) Frame length validation

2011-03-20 Thread Janne Johansson
2011/3/20 Loganaden Velvindron > Hi, this diff also discards packets larger than maximum buffer size. > > Please test. > > Index: src/sys/dev/usb/if_urndis.c > === > RCS file: /cvs/src/sys/dev/usb/if_urndis.c,v > retrieving revision

Re: urndis(4) Frame length validation

2011-03-20 Thread Loganaden Velvindron
Here's a less confusing diff. Index: src/sys/dev/usb/if_urndis.c === RCS file: /cvs/src/sys/dev/usb/if_urndis.c,v retrieving revision 1.29 diff -u -p -r1.29 if_urndis.c --- src/sys/dev/usb/if_urndis.c 25 Jan 2011 20:03:35 - 1

urndis(4) Frame length validation

2011-03-19 Thread Loganaden Velvindron
Hi, this diff also discards packets larger than maximum buffer size. Please test. Index: src/sys/dev/usb/if_urndis.c === RCS file: /cvs/src/sys/dev/usb/if_urndis.c,v retrieving revision 1.29 diff -u -p -r1.29 if_urndis.c --- src/sys/