Re: Update to pcap-filter.5/tcpdump.8 (was: update to tcpdump(8))

2021-09-06 Thread Theo de Raadt
I think this is a good enough start, as-is. A big improvement. Further iterations can refine the few funny sentences where tcpdump and pcap-filter diverge. I'm not worried about them, they just come off as strange wording, or irrelevancies. Jason McIntyre wrote: > On Sun, Sep 05, 2021 at 04:4

Re: Update to pcap-filter.5/tcpdump.8 (was: update to tcpdump(8))

2021-09-05 Thread Jason McIntyre
On Sun, Sep 05, 2021 at 04:43:34PM +0200, Denis Fondras wrote: > Le Sat, Sep 04, 2021 at 09:57:10PM +0100, Jason McIntyre a ?crit : > > the diff looks ok to me. but run any doc changes through "mandoc > > -Tlint", and look at any issues your diff may have introduced. in this > > case it's just trai

Update to pcap-filter.5/tcpdump.8 (was: update to tcpdump(8))

2021-09-05 Thread Denis Fondras
Le Sat, Sep 04, 2021 at 09:57:10PM +0100, Jason McIntyre a écrit : > the diff looks ok to me. but run any doc changes through "mandoc > -Tlint", and look at any issues your diff may have introduced. in this > case it's just trailing whitespace, but it's super helpful to check your > work. > Thank

Re: update to tcpdump(8)

2021-09-04 Thread Jason McIntyre
On Sat, Sep 04, 2021 at 07:26:21PM +0200, Denis Fondras wrote: > Le Thu, Sep 02, 2021 at 08:36:06AM -0600, Theo de Raadt a ?crit : > > I think the following approach will work. > > > > 1. changes from tcpdump.8 -r1.00 to -rHEAD need merging into pcap-filter.5 > > > > Here is a diff for this step

Re: update to tcpdump(8)

2021-09-04 Thread Denis Fondras
Le Thu, Sep 02, 2021 at 08:36:06AM -0600, Theo de Raadt a écrit : > I think the following approach will work. > > 1. changes from tcpdump.8 -r1.00 to -rHEAD need merging into pcap-filter.5 > Here is a diff for this step. I have one question though. tcpdump.8 has : " tcpdump does not currently

Re: update to tcpdump(8)

2021-09-02 Thread Theo de Raadt
I think the following approach will work. 1. changes from tcpdump.8 -r1.00 to -rHEAD need merging into pcap-filter.5 2) DESCRIPTION from pcap-filter body is then copied into tcpdump, replacing the same chunk. What I see is far more authoritative. 3) EXAMPLES copied from pcap-filter, and nee

Re: update to tcpdump(8)

2021-09-02 Thread Jason McIntyre
On Thu, Sep 02, 2021 at 04:27:41PM +0200, Denis Fondras wrote: > Le Thu, Sep 02, 2021 at 07:49:25AM +0100, Jason McIntyre a ?crit : > > why not just paste in the body of pcap-filter in then and we can try and > > keep them in sync thereafter? > > > > OK, I will do that. I am not confident it will

Re: update to tcpdump(8)

2021-09-02 Thread Denis Fondras
Le Thu, Sep 02, 2021 at 07:49:25AM +0100, Jason McIntyre a écrit : > why not just paste in the body of pcap-filter in then and we can try and > keep them in sync thereafter? > OK, I will do that. I am not confident it will stay in sync over time :D

Re: update to tcpdump(8)

2021-09-02 Thread Jason McIntyre
On Thu, Sep 02, 2021 at 03:33:17AM -0600, Theo de Raadt wrote: > Jason McIntyre wrote: > > > On Thu, Sep 02, 2021 at 12:44:56AM -0600, Theo de Raadt wrote: > > > Jason McIntyre wrote: > > > > > > > then i guess i would propose doing exactly that: removing the bulk of > > > > the text describing

Re: update to tcpdump(8)

2021-09-02 Thread Theo de Raadt
Jason McIntyre wrote: > On Thu, Sep 02, 2021 at 12:44:56AM -0600, Theo de Raadt wrote: > > Jason McIntyre wrote: > > > > > then i guess i would propose doing exactly that: removing the bulk of > > > the text describing primitives and qualifiers and leave a pointer to > > > pcap-filter.3. we cou

Re: update to tcpdump(8)

2021-09-01 Thread Jason McIntyre
On Thu, Sep 02, 2021 at 12:44:56AM -0600, Theo de Raadt wrote: > Jason McIntyre wrote: > > > then i guess i would propose doing exactly that: removing the bulk of > > the text describing primitives and qualifiers and leave a pointer to > > pcap-filter.3. we could leave a brief description of the

Re: update to tcpdump(8)

2021-09-01 Thread Theo de Raadt
Jason McIntyre wrote: > then i guess i would propose doing exactly that: removing the bulk of > the text describing primitives and qualifiers and leave a pointer to > pcap-filter.3. we could leave a brief description of the main > qualifiers, and perhaps just a list of valid keywords for the othe

Re: update to tcpdump(8)

2021-09-01 Thread Jason McIntyre
On Wed, Sep 01, 2021 at 08:28:14PM +0200, Denis Fondras wrote: > Le Wed, Sep 01, 2021 at 06:42:54PM +0100, Jason McIntyre a ?crit : > > On Wed, Sep 01, 2021 at 06:15:04PM +0200, Denis Fondras wrote: > > > I was searching for the sampling command of tcpdump but could not find it > > > in the > > >

Re: update to tcpdump(8)

2021-09-01 Thread Denis Fondras
Le Wed, Sep 01, 2021 at 06:42:54PM +0100, Jason McIntyre a écrit : > On Wed, Sep 01, 2021 at 06:15:04PM +0200, Denis Fondras wrote: > > I was searching for the sampling command of tcpdump but could not find it > > in the > > manual. In fact it is missing some primitives compared to pcap-filter >

Re: update to tcpdump(8)

2021-09-01 Thread Jason McIntyre
On Wed, Sep 01, 2021 at 06:15:04PM +0200, Denis Fondras wrote: > I was searching for the sampling command of tcpdump but could not find it in > the > manual. In fact it is missing some primitives compared to pcap-filter manual. > hi. it looks like there's a whole heap of duplication going on he

update to tcpdump(8)

2021-09-01 Thread Denis Fondras
I was searching for the sampling command of tcpdump but could not find it in the manual. In fact it is missing some primitives compared to pcap-filter manual. Index: tcpdump.8 === RCS file: /cvs/src/usr.sbin/tcpdump/tcpdump.8,v retrie