Re: unwind: log missing config file

2019-11-26 Thread Klemens Nanni
On Tue, Nov 26, 2019 at 12:59:31PM -0600, Matthew Martin wrote: > Another option would be to pass NULL for the default config which avoids > adding another parameter. Something like the below diff. Fine with me; I briefly tried using NULL but did not get it right since I always set filename before

Re: unwind: log missing config file

2019-11-26 Thread Florian Obser
I suppose this is the least worst way to handle it. OK On Sun, Nov 24, 2019 at 10:03:57PM +0100, Klemens Nanni wrote: > On Tue, Nov 19, 2019 at 03:53:16AM +0100, Florian Obser wrote: > > I think the file doesn't exist but it's fine check is in the wrong > > place. It's also stupid that it doesn't

Re: unwind: log missing config file

2019-11-25 Thread Klemens Nanni
On Tue, Nov 19, 2019 at 03:53:16AM +0100, Florian Obser wrote: > I think the file doesn't exist but it's fine check is in the wrong > place. It's also stupid that it doesn't fatal(!) for unwind -f > nonexistent. I think this needs to be handled further up in main. > Maybe. I'll have a look if I don

Re: unwind: log missing config file

2019-11-19 Thread Stuart Henderson
On 2019/11/19 20:48, Klemens Nanni wrote: > On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > > With that, my initial case is no longer misleading; alternatively, I > > > can implement the dash semantic, but that's

Re: unwind: log missing config file

2019-11-19 Thread Klemens Nanni
On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > With that, my initial case is no longer misleading; alternatively, I > > can implement the dash semantic, but that's another diff. > Hm, that makes the default setup

Re: unwind: log missing config file

2019-11-19 Thread Otto Moerbeek
On Tue, Nov 19, 2019 at 03:53:16AM +0100, Florian Obser wrote: > On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > > With that, my initial case is no longer misleading; alternatively, I > > > can implement the das

Re: unwind: log missing config file

2019-11-18 Thread Claudio Jeker
On Mon, Nov 18, 2019 at 07:57:09PM -0700, Theo de Raadt wrote: > Florian Obser wrote: > > > On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > > > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > > > With that, my initial case is no longer misleading; alternativel

Re: unwind: log missing config file

2019-11-18 Thread Theo de Raadt
Florian Obser wrote: > On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > > With that, my initial case is no longer misleading; alternatively, I > > > can implement the dash semantic, but that's another diff. > >

Re: unwind: log missing config file

2019-11-18 Thread Florian Obser
On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > With that, my initial case is no longer misleading; alternatively, I > > can implement the dash semantic, but that's another diff. > Hm, that makes the default setup

Re: unwind: log missing config file

2019-11-18 Thread Klemens Nanni
On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > With that, my initial case is no longer misleading; alternatively, I > can implement the dash semantic, but that's another diff. Hm, that makes the default setup (no /etc/unwind.conf, empty unwind_flags) always print a warning, which

unwind: log missing config file

2019-11-18 Thread Klemens Nanni
I gave unwind.conf(5) a read and wanted to test the following: $ echo preference dhcp | unwind -vnf- preference { DoT forwarder recursor dhcp stub } First, I thought unwind had a parser bug and would ignore my preference, but turns out it simply does not treat "-" as standard inpu