Re: un-boolean_t i386's pmap

2019-12-05 Thread Otto Moerbeek
On Thu, Dec 05, 2019 at 04:12:01PM +0100, Martin Pieuchot wrote: > On 05/12/19(Thu) 11:57, Otto Moerbeek wrote: > > On Thu, Dec 05, 2019 at 12:38:34PM +0100, Martin Pieuchot wrote: > > > > > ok? > > > > I'm no kernel hacker but I really do not see the point. > > Most of the kernel doesn't use a

Re: un-boolean_t i386's pmap

2019-12-05 Thread Martin Pieuchot
On 05/12/19(Thu) 11:57, Otto Moerbeek wrote: > On Thu, Dec 05, 2019 at 12:38:34PM +0100, Martin Pieuchot wrote: > > > ok? > > I'm no kernel hacker but I really do not see the point. Most of the kernel doesn't use any type for boolean. The exception is UVM which uses its own boolean_t. This typ

Re: un-boolean_t i386's pmap

2019-12-05 Thread Otto Moerbeek
On Thu, Dec 05, 2019 at 12:38:34PM +0100, Martin Pieuchot wrote: > ok? I'm no kernel hacker but I really do not see the point. boolean_t helps to see if a functions is supposed to return a boolean instead of an error code. I hate reading a function and having to guess if 0 is supposed to mean su

un-boolean_t i386's pmap

2019-12-05 Thread Martin Pieuchot
ok? Index: i386/pmap.c === RCS file: /cvs/src/sys/arch/i386/i386/pmap.c,v retrieving revision 1.204 diff -u -p -r1.204 pmap.c --- i386/pmap.c 18 Jan 2019 01:34:50 - 1.204 +++ i386/pmap.c 5 Dec 2019 11:23:20 - @@ -403,7 +4