Re: two bge(4) bugfixes

2015-11-01 Thread Miod Vallat
> This chunk doesn't make sense to me. The code is supposed to write a > magic value into SRAM, not into a register. If I understand if_bgereg.h correctly, access to the SRAM can be performed either through a simple indirect access (write address to the index register, read from or write to the d

Re: two bge(4) bugfixes

2015-10-17 Thread Miod Vallat
> > Date: Thu, 15 Oct 2015 17:23:21 + > > From: Miod Vallat > > > > The following diff attempts to fix two small bge(4) bugs: > > > > - the first chunk fixes what seems to be a logic error on BCM 5720, > > where the code attemps to preserve the state of four bits, but these > > have actu

Re: two bge(4) bugfixes

2015-10-16 Thread Mark Kettenis
> Date: Thu, 15 Oct 2015 17:23:21 + > From: Miod Vallat > > The following diff attempts to fix two small bge(4) bugs: > > - the first chunk fixes what seems to be a logic error on BCM 5720, > where the code attemps to preserve the state of four bits, but these > have actually already bee

Re: two bge(4) bugfixes

2015-10-16 Thread Martin Pieuchot
On 15/10/15(Thu) 17:23, Miod Vallat wrote: > The following diff attempts to fix two small bge(4) bugs: > > - the first chunk fixes what seems to be a logic error on BCM 5720, > where the code attemps to preserve the state of four bits, but these > have actually already been set in the local va

two bge(4) bugfixes

2015-10-15 Thread Miod Vallat
The following diff attempts to fix two small bge(4) bugs: - the first chunk fixes what seems to be a logic error on BCM 5720, where the code attemps to preserve the state of four bits, but these have actually already been set in the local variable by the call to bge_dma_swap_options() immedi