Re: tpm(4): don't use tvtohz(9)

2021-01-14 Thread Mark Kettenis
> Date: Wed, 13 Jan 2021 21:39:37 -0600 > From: Scott Cheloha > > On Fri, Jan 08, 2021 at 08:21:14PM +0100, Florian Obser wrote: > > > > My x1 gen 2 seems to have a TPM 1.2 chip. Or can emulate one? > > The bios is confusing. I had it disabled until now. >

Re: tpm(4): don't use tvtohz(9)

2021-01-13 Thread Scott Cheloha
oha > > > > > > > > On Wed, Jan 06, 2021 at 11:26:27PM +0100, Mark Kettenis wrote: > > > > > > Date: Wed, 6 Jan 2021 16:16:27 -0600 > > > > > > From: Scott Cheloha > > > > > > > > > > > > On W

Re: tpm(4): don't use tvtohz(9)

2021-01-08 Thread Florian Obser
Kettenis wrote: > > > > > Date: Wed, 6 Jan 2021 16:16:27 -0600 > > > > > From: Scott Cheloha > > > > > > > > > > On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > > > > > > As mentioned in a prior mail,

Re: tpm(4): don't use tvtohz(9)

2021-01-08 Thread Scott Cheloha
gt; From: Scott Cheloha > > > > > > > > On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > > > > > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > > > > > the tree. > > > > > > >

Re: tpm(4): don't use tvtohz(9)

2021-01-08 Thread Mark Kettenis
-0600, Scott Cheloha wrote: > > > > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > > > > the tree. > > > > > > > > However, we don't need to use tvtohz(9) in tpm(4) at all. Converting > > > > from milliseconds

Re: tpm(4): don't use tvtohz(9)

2021-01-08 Thread Scott Cheloha
On Wed, Jan 06, 2021 at 11:26:27PM +0100, Mark Kettenis wrote: > > Date: Wed, 6 Jan 2021 16:16:27 -0600 > > From: Scott Cheloha > > > > On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > > > As mentioned in a prior mail, tpm(4) is the last us

Re: tpm(4): don't use tvtohz(9)

2021-01-06 Thread Mark Kettenis
> Date: Wed, 6 Jan 2021 16:16:27 -0600 > From: Scott Cheloha > > On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > > the tree. > > > > However, we don't need to us

Re: tpm(4): don't use tvtohz(9)

2021-01-06 Thread Scott Cheloha
On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > the tree. > > However, we don't need to use tvtohz(9) in tpm(4) at all. Converting > from milliseconds to ticks is trivial. Using an inter

Re: tpm(4): don't use tvtohz(9)

2021-01-06 Thread Klemens Nanni
On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > the tree. > > However, we don't need to use tvtohz(9) in tpm(4) at all. Converting > from milliseconds to ticks is trivial. Using an inter

tpm(4): don't use tvtohz(9)

2021-01-06 Thread Scott Cheloha
As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in the tree. However, we don't need to use tvtohz(9) in tpm(4) at all. Converting from milliseconds to ticks is trivial. Using an intermediary timeval is just pointless indirection. With this committed I will be able to r

Re: tpm(4): removing tvtohz(9)?

2020-12-19 Thread Scott Cheloha
> On Dec 18, 2020, at 20:16, joshua stein wrote: > > On Fri, 18 Dec 2020 at 18:58:43 -0600, Scott Cheloha wrote: >> Hi, >> >> tpm(4) is the last driver in the tree using tvtohz(9). There are no >> remaining callers using tstohz(9), so if and when we remov

Re: tpm(4): removing tvtohz(9)?

2020-12-18 Thread joshua stein
On Fri, 18 Dec 2020 at 18:58:43 -0600, Scott Cheloha wrote: > Hi, > > tpm(4) is the last driver in the tree using tvtohz(9). There are no > remaining callers using tstohz(9), so if and when we remove tvtohz(9) > from tpm(4) we can remove both interfaces from the tree. >

tpm(4): removing tvtohz(9)?

2020-12-18 Thread Scott Cheloha
Hi, tpm(4) is the last driver in the tree using tvtohz(9). There are no remaining callers using tstohz(9), so if and when we remove tvtohz(9) from tpm(4) we can remove both interfaces from the tree. tpm(4) is tricky because it converts timeouts from milliseconds to ticks and then doesn'

Re: Thinkpad X1 5th gen TPM chip

2019-03-11 Thread Mike Larkin
your diagnosis! -ml > Mon Mar 11 23:47:54 GMT 2019 Mike Larkin : > > > On Mon, Mar 11, 2019 at 11:24:42AM +, Edd Barrett wrote: > > > Hi, > > > > > > I was looking at the manual page for tpm(4) and noticed that it has > > > something to to w

Re: Thinkpad X1 5th gen TPM chip

2019-03-11 Thread Edd Barrett
un Arch Linux on their X1 5gs and have no problem suspending. Cheers! Edd Barrett Mon Mar 11 23:47:54 GMT 2019 Mike Larkin : > On Mon, Mar 11, 2019 at 11:24:42AM +, Edd Barrett wrote: > > Hi, > > > > I was looking at the manual page for tpm(4) and noticed that

Re: Thinkpad X1 5th gen TPM chip

2019-03-11 Thread Mike Larkin
On Mon, Mar 11, 2019 at 11:24:42AM +, Edd Barrett wrote: > Hi, > > I was looking at the manual page for tpm(4) and noticed that it has > something to to with suspend/resume: > > > Functionality is limited to instructing the device to save its > > st

Thinkpad X1 5th gen TPM chip

2019-03-11 Thread Edd Barrett
Hi, I was looking at the manual page for tpm(4) and noticed that it has something to to with suspend/resume: > Functionality is limited to instructing the device to save its > state before a system suspend. The X1 5th generation has a MSFT0101 TPM chip which we don't y

Re: tpm

2016-08-03 Thread Mark Kettenis
> Date: Wed, 3 Aug 2016 09:21:33 -0500 > From: joshua stein > > Newer machines with TPM chips can have trouble suspending or > resuming, because the TPM chip is not instructed to save its state > properly before suspend. On ThinkPads this can prevent suspend from > working,