> On 26 Jun 2020, at 23:12, Klemens Nanni wrote:
>
> On Fri, Jun 26, 2020 at 11:07:54PM +0300, Vitaliy Makkoveev wrote:
>> What about “pageshift = 0;” at usr.bin/top/machine.c:216 ?
> Could be removed as well but I left it in there intentionally to keep
> this block of code readable since page
> On 26 Jun 2020, at 22:00, Klemens Nanni wrote:
>
> Those are global variables are (zero) initialised as such already and
> machine_init() is called only once upon startup.
>
> Feedback? OK?
>
>
> Index: machine.c
> ===
> RCS
On Fri, Jun 26, 2020 at 11:07:54PM +0300, Vitaliy Makkoveev wrote:
> What about “pageshift = 0;” at usr.bin/top/machine.c:216 ?
Could be removed as well but I left it in there intentionally to keep
this block of code readable since pageshift is not only set but used
immediately afterwards as well.
Those are global variables are (zero) initialised as such already and
machine_init() is called only once upon startup.
Feedback? OK?
Index: machine.c
===
RCS file: /cvs/src/usr.bin/top/machine.c,v
retrieving revision 1.105
diff -u -
