Re: top: merge duplicate username parsing code into filteruser()

2018-10-27 Thread Klemens Nanni
On Sat, Oct 27, 2018 at 06:28:41PM +0200, Klemens Nanni wrote: > + } else > + uidp = &ps.uid; > + ps.huid = -1; And here I was sloppy. Sorry. Index: top.c === RCS file: /cvs/src/usr.bin/top/top.c,v retrievi

Re: top: merge duplicate username parsing code into filteruser()

2018-10-27 Thread Klemens Nanni
On Sat, Oct 27, 2018 at 06:05:33PM +0200, Klemens Nanni wrote: > Reduce four almost identical uid_from_user(3) calls into one by handling > negation once in a way show/hide agnostic way. > > I want to add support for UIDs besides usernames, so this diff is a > preliminary cleanup to allow for this

top: merge duplicate username parsing code into filteruser()

2018-10-27 Thread Klemens Nanni
Reduce four almost identical uid_from_user(3) calls into one by handling negation once in a way show/hide agnostic way. I want to add support for UIDs besides usernames, so this diff is a preliminary cleanup to allow for this feature addition to happen in the newly introduced function. The intern