Re: tidy syscall_mi.h

2016-04-13 Thread Theo de Raadt
>> Date: Thu, 7 Apr 2016 13:10:23 +0200 >> From: Michal Mazurek >> >> Depending on the NOLOCK flag, the KERNEL_LOCK will, or will not be acquired >> before calling pledge_syscall(). I therefore conclude that KERNEL_LOCK >> is not needed to call pledge_syscall(). > >It really depends on what the b

Re: tidy syscall_mi.h

2016-04-07 Thread Ted Unangst
Michal Mazurek wrote: > Depending on the NOLOCK flag, the KERNEL_LOCK will, or will not be acquired > before calling pledge_syscall(). I therefore conclude that KERNEL_LOCK > is not needed to call pledge_syscall(). > > Also remove the goto. The code is simple enough to avoid it easily. > > I thin

Re: tidy syscall_mi.h

2016-04-07 Thread Mark Kettenis
> Date: Thu, 7 Apr 2016 13:10:23 +0200 > From: Michal Mazurek > > Depending on the NOLOCK flag, the KERNEL_LOCK will, or will not be acquired > before calling pledge_syscall(). I therefore conclude that KERNEL_LOCK > is not needed to call pledge_syscall(). It really depends on what the behaviour

tidy syscall_mi.h

2016-04-07 Thread Michal Mazurek
Depending on the NOLOCK flag, the KERNEL_LOCK will, or will not be acquired before calling pledge_syscall(). I therefore conclude that KERNEL_LOCK is not needed to call pledge_syscall(). Also remove the goto. The code is simple enough to avoid it easily. I think this complexity was caused by some