Re: tcpstat percpu counters

2017-02-07 Thread Alexander Bluhm
On Mon, Feb 06, 2017 at 07:44:23PM +0100, Jeremie Courreges-Anglas wrote: > Revised after the change in the counters api. Passed make release on > amd64, runtime tested on GENERIC armv7 and GENERIC.MP amd64. OK bluhm@ > > > Index: net/pf.c >

Re: tcpstat percpu counters

2017-02-06 Thread Jeremie Courreges-Anglas
Jeremie Courreges-Anglas writes: [...] I've removed the TCPSTAT_INLINE code. If we want to experiment with inlined/not inlined counters, it is probably more interesting to make that choice elsewhere. > Anyway, tcpstat diff below, a bit ugly because that struct is a mix of > uint32_t and uint64

tcpstat percpu counters (and kernel size growth)

2017-01-31 Thread Jeremie Courreges-Anglas
Maybe I'm comparing apples and oranges, but I got curious and compared the size of various kernels on amd64: * -current GENERIC: textdatabss dec hex 9197408 269192 684032 101506329ae2e8 * percpu tcpstat, not inlined, GENERIC: textdatabss dec hex