Re: tcpdump -A: really printable characters

2015-07-13 Thread ludovic coues
2015-07-13 13:14 GMT+02:00 : > Ignore this if it wastes time, what is 'vis' and is it platform / > architecture specific? Rather means to get what it was planned to > achieve probably.. > $ man vis [...] NAME vis ─ display non-printable characters in a visual format -- Cordialement, Coues

Re: tcpdump -A: really printable characters

2015-07-13 Thread lists
Historic overview of OpenBSD across platforms has always been intriguing to say the least. > I sent a mail to naddy mentioning that a long time ago (feels like 10 > years ago) we talked about using vis, but this would have made our Ignore this if it wastes time, what is 'vis' and is it platform /

Re: tcpdump -A: really printable characters

2015-07-12 Thread Sebastien Marie
On Sun, Jul 12, 2015 at 01:53:54PM +0200, Christian Weisgerber wrote: > Sebastien Marie: > > > > --- tcpdump.c 18 Apr 2015 18:28:38 - 1.70 > > > +++ tcpdump.c 11 Jul 2015 20:35:11 - > > > @@ -603,8 +603,10 @@ default_print_ascii(const u_char *cp, un > > > printf("\n"); > > >

Re: tcpdump -A: really printable characters

2015-07-12 Thread Christian Weisgerber
Sebastien Marie: > > --- tcpdump.c 18 Apr 2015 18:28:38 - 1.70 > > +++ tcpdump.c 11 Jul 2015 20:35:11 - > > @@ -603,8 +603,10 @@ default_print_ascii(const u_char *cp, un > > printf("\n"); > > for (i = 0; i < length; i++) { > > c = cp[i]; > > -

Re: tcpdump -A: really printable characters

2015-07-11 Thread Theo de Raadt
> > Index: tcpdump.c > > === > > RCS file: /cvs/src/usr.sbin/tcpdump/tcpdump.c,v > > retrieving revision 1.70 > > diff -u -p -r1.70 tcpdump.c > > --- tcpdump.c 18 Apr 2015 18:28:38 - 1.70 > > +++ tcpdump.c 11 Jul 2

Re: tcpdump -A: really printable characters

2015-07-11 Thread Sebastien Marie
On Sat, Jul 11, 2015 at 10:45:44PM +0200, Christian Weisgerber wrote: > I was looking at some SIP traffic (urgh) with tcpdump -A | less and > wondered why ^K and ^L were considered printable characters. Let's > tighten this a bit. Equivalent to what tcpdump.org has. >

tcpdump -A: really printable characters

2015-07-11 Thread Christian Weisgerber
I was looking at some SIP traffic (urgh) with tcpdump -A | less and wondered why ^K and ^L were considered printable characters. Let's tighten this a bit. Equivalent to what tcpdump.org has. OK? Index: tcpdump.c === RCS file:

Re: Trimming tcpdump a bit

2014-11-25 Thread Stuart Henderson
On 2014/11/24 09:59, Theo de Raadt wrote: > Thing is, in a few cases we have de-forked as well. For instance, in > less(1). Hmm, kind of relevant recently.. Fortunately we don't have ours use lesspipe by default :-)

Re: Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
On 24 November 2014 at 16:42, Mike Belopuhov wrote: > Hi, > > I've been trying to fix a bug in tcpdump but the rottenness > of the current code base with it's horrendous APIs is just > getting in the way. What if we trimmed it a bit, say killed > all those pesky 'register' values, kill protocols

Re: Trimming tcpdump a bit

2014-11-24 Thread Theo de Raadt
> >> I've been trying to fix a bug in tcpdump but the rottenness > >> of the current code base with it's horrendous APIs is just > >> getting in the way. What if we trimmed it a bit, say killed > >> all those pesky 'register' values, That would be cleanup, which then allows the code to be improve

Re: Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
On 24 November 2014 at 18:01, Mike Belopuhov wrote: > On 24 November 2014 at 17:20, Mike Belopuhov wrote: >> On 24 November 2014 at 16:42, Mike Belopuhov wrote: >>> Hi, >>> >>> I've been trying to fix a bug in tcpdump but the rottenness >>> of the current code base with it's horrendous APIs is j

Re: Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
On 24 November 2014 at 17:20, Mike Belopuhov wrote: > On 24 November 2014 at 16:42, Mike Belopuhov wrote: >> Hi, >> >> I've been trying to fix a bug in tcpdump but the rottenness >> of the current code base with it's horrendous APIs is just >> getting in the way. What if we trimmed it a bit, say

Re: Trimming tcpdump a bit

2014-11-24 Thread Theo de Raadt
> On 2014/11/24 16:42, Mike Belopuhov wrote: > > Hi, > > > > I've been trying to fix a bug in tcpdump but the rottenness > > of the current code base with it's horrendous APIs is just > > getting in the way. What if we trimmed it a bit, say killed > > all those pesky 'register' values, kill proto

Re: Trimming tcpdump a bit

2014-11-24 Thread Stuart Henderson
On 2014/11/24 16:42, Mike Belopuhov wrote: > Hi, > > I've been trying to fix a bug in tcpdump but the rottenness > of the current code base with it's horrendous APIs is just > getting in the way. What if we trimmed it a bit, say killed > all those pesky 'register' values, kill protocols that we >

Re: Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
On 24 November 2014 at 16:42, Mike Belopuhov wrote: > Hi, > > I've been trying to fix a bug in tcpdump but the rottenness > of the current code base with it's horrendous APIs is just > getting in the way. What if we trimmed it a bit, say killed > all those pesky 'register' values, kill protocols

Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
Hi, I've been trying to fix a bug in tcpdump but the rottenness of the current code base with it's horrendous APIs is just getting in the way. What if we trimmed it a bit, say killed all those pesky 'register' values, kill protocols that we cannot really test (appletalk, fddi, etc.), kill dissect

Re: tcpdump -A

2012-07-10 Thread Stuart Henderson
On 2012/07/10 14:15, Mike Small wrote: > Stuart Henderson writes: > > > +/* dump the text from the buffer */ > > +void > > +default_print_ascii(const u_char *cp, unsigned int length, unsigned int > > offset) > > +{ > > + int c, i; > > + > > + printf("\n"); > > + for (i = 0; i < length; i++

Re: tcpdump -A

2012-07-10 Thread Mike Small
Stuart Henderson writes: > +/* dump the text from the buffer */ > +void > +default_print_ascii(const u_char *cp, unsigned int length, unsigned int > offset) > +{ > + int c, i; > + > + printf("\n"); > + for (i = 0; i < length; i++) { > + c = cp[i]; > + c = ispr

tcpdump -A

2012-07-10 Thread Stuart Henderson
adds support for -A for tcpdump, to print captured text without the hex dump. can be useful if you're watching text-based protocols like HTTP or SIP. tcpdump.org uses the same flag (this isn't their code though). comments? OK? Index: tcpdump.8 =