On Sat, Nov 10, 2018 at 02:01:56PM +0100, Klemens Nanni wrote:
> On Sat, Nov 10, 2018 at 10:05:18AM +0100, Denis Fondras wrote:
> > 'tcpdump vlan $vlan_number' will not return anything if priority is not 0.
> >
> > Fix that by not comparing vlan number against priority.
> > Also deny usage of vlan
On Sat, Nov 10, 2018 at 02:25:49PM +0100, Klemens Nanni wrote:
> On Sat, Nov 10, 2018 at 02:01:56PM +0100, Klemens Nanni wrote:
> > OK kn with using defines, see inline with one other irrelevant nit.
> We should of course check the lower bound, too.
>
> > > + if (vlan_num > 4095) {
> if (vla
On Sat, Nov 10, 2018 at 02:01:56PM +0100, Klemens Nanni wrote:
> OK kn with using defines, see inline with one other irrelevant nit.
We should of course check the lower bound, too.
> > + if (vlan_num > 4095) {
if (vlan_num < EVL_VLID_MIN || vlan_num > EVL_VLID_MAX) {
On Sat, Nov 10, 2018 at 10:05:18AM +0100, Denis Fondras wrote:
> 'tcpdump vlan $vlan_number' will not return anything if priority is not 0.
>
> Fix that by not comparing vlan number against priority.
> Also deny usage of vlan number greater than 4095 while at it.
4095 is reserved, 4094 is the maxi
'tcpdump vlan $vlan_number' will not return anything if priority is not 0.
Fix that by not comparing vlan number against priority.
Also deny usage of vlan number greater than 4095 while at it.
Index: gencode.c
===
RCS file: /cvs/src/
