Re: tcpdump(8) USB support

2018-02-01 Thread David Gwynne
> On 31 Jan 2018, at 12:39 am, Martin Pieuchot wrote: > > On 30/01/18(Tue) 16:37, David Gwynne wrote: >>> [...] >>> bpfsdetach takes the reference to a bpf interface that bpfsattach >>> returns. the manpage likely isnt clear. the diff below fixes it. >>> >>> ive also added a bpf_tap_hdr funct

Re: tcpdump(8) USB support

2018-01-30 Thread Martin Pieuchot
On 30/01/18(Tue) 16:37, David Gwynne wrote: > > [...] > > bpfsdetach takes the reference to a bpf interface that bpfsattach > > returns. the manpage likely isnt clear. the diff below fixes it. > > > > ive also added a bpf_tap_hdr function that lets you pass a header > > along with a flat buffer.

Re: tcpdump(8) USB support

2018-01-29 Thread David Gwynne
On Tue, Jan 30, 2018 at 04:32:11PM +1000, David Gwynne wrote: > On Fri, Jan 26, 2018 at 07:22:20AM +0100, Martin Pieuchot wrote: > > On 25/01/18(Thu) 14:55, Bryan Steele wrote: > > > On Thu, Jan 25, 2018 at 07:00:43PM +0100, Martin Pieuchot wrote: > > > > Diff below adds support for dumping USB tra

Re: tcpdump(8) USB support

2018-01-29 Thread David Gwynne
On Fri, Jan 26, 2018 at 07:22:20AM +0100, Martin Pieuchot wrote: > On 25/01/18(Thu) 14:55, Bryan Steele wrote: > > On Thu, Jan 25, 2018 at 07:00:43PM +0100, Martin Pieuchot wrote: > > > Diff below adds support for dumping USB transfers via bpf(4), including > > > the tcpdump(8) bits. > > > > > > I

Re: tcpdump(8) USB support

2018-01-25 Thread Martin Pieuchot
On 25/01/18(Thu) 14:55, Bryan Steele wrote: > On Thu, Jan 25, 2018 at 07:00:43PM +0100, Martin Pieuchot wrote: > > Diff below adds support for dumping USB transfers via bpf(4), including > > the tcpdump(8) bits. > > > > I'd like special review of the new bpf_tap(9) function I'm introducing: > >

Re: tcpdump(8) USB support

2018-01-25 Thread Bryan Steele
On Thu, Jan 25, 2018 at 07:00:43PM +0100, Martin Pieuchot wrote: > Diff below adds support for dumping USB transfers via bpf(4), including > the tcpdump(8) bits. > > I'd like special review of the new bpf_tap(9) function I'm introducing: > - is there a way to pass the header as a different buffe

tcpdump(8) USB support

2018-01-25 Thread Martin Pieuchot
Diff below adds support for dumping USB transfers via bpf(4), including the tcpdump(8) bits. I'd like special review of the new bpf_tap(9) function I'm introducing: - is there a way to pass the header as a different buffer? - is _bpf_tap() the best way to share code with bpf_mtap(9)? Concerni