Re: tcp_input.c: recursive splsoftnet()

2016-11-16 Thread Alexander Bluhm
On Wed, Nov 16, 2016 at 09:58:00AM +0100, Martin Pieuchot wrote: > On 15/11/16(Tue) 16:36, Alexander Bluhm wrote: > > [...] > > You are a bit inconsistent wether you remove the {} from one line > > if blocks. > > That should fix my inconsistencies. OK bluhm@ > > Index: netinet/tcp_input.c > ===

Re: tcp_input.c: recursive splsoftnet()

2016-11-16 Thread Martin Pieuchot
On 15/11/16(Tue) 16:36, Alexander Bluhm wrote: > [...] > You are a bit inconsistent wether you remove the {} from one line > if blocks. That should fix my inconsistencies. Index: netinet/tcp_input.c === RCS file: /cvs/src/sys/netinet

Re: tcp_input.c: recursive splsoftnet()

2016-11-15 Thread Alexander Bluhm
On Tue, Nov 15, 2016 at 04:03:40PM +0100, Martin Pieuchot wrote: > Assert that the sync cache functions are always called under the correct > IPL. > > This kill some more recursive splsoftnet(). > > While here keep local declarations local, this makes my life easier. > This way I know I don't nee

tcp_input.c: recursive splsoftnet()

2016-11-15 Thread Martin Pieuchot
Assert that the sync cache functions are always called under the correct IPL. This kill some more recursive splsoftnet(). While here keep local declarations local, this makes my life easier. This way I know I don't need to grep the whole tree to look where the functions are called. Index: netine