Re: struct ifnet: remove unused if_switchport member

2022-08-30 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 05:40:00PM +, Klemens Nanni wrote: > Full ports diff for completeness. Done with $ infrastructure/bin/portbump -r \ devel/libgtop2 \ games/warzone2100 \ mail/mozilla-thunderbird \ multimedia/gstrea

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 06:15:50PM +0100, Stuart Henderson wrote: > On 2022/08/26 16:50, Klemens Nanni wrote: > > Running the packages.txt files through 'sort -u' and 'comm -12' and > > filtering for ports we actually have leaves us with > > > > aircrack-ng > > firefox > > firefox-esr

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Stuart Henderson
On 2022/08/26 16:50, Klemens Nanni wrote: > Running the packages.txt files through 'sort -u' and 'comm -12' and > filtering for ports we actually have leaves us with > > aircrack-ng > firefox > firefox-esr > gst-plugins-bad1.0 > gst-plugins-bad1.0-contrib > libg

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 04:08:34PM +, Klemens Nanni wrote: > On Fri, Aug 26, 2022 at 09:53:35AM -0600, Theo de Raadt wrote: > > Klemens Nanni wrote: > > > > > On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > > > > On 2022/08/26 09:49, Klemens Nanni wrote: > > > > > grep and

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Theo de Raadt
Mark Kettenis wrote: > > From: "Theo de Raadt" > > Date: Fri, 26 Aug 2022 09:53:35 -0600 > > > > Klemens Nanni wrote: > > > > > On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > > > > On 2022/08/26 09:49, Klemens Nanni wrote: > > > > > grep and CVS agree that this is a switc

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Fri, 26 Aug 2022 09:53:35 -0600 > > Klemens Nanni wrote: > > > On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > > > On 2022/08/26 09:49, Klemens Nanni wrote: > > > > grep and CVS agree that this is a switch(4) left-over. > > > > > > > > OK? >

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 09:53:35AM -0600, Theo de Raadt wrote: > Klemens Nanni wrote: > > > On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > > > On 2022/08/26 09:49, Klemens Nanni wrote: > > > > grep and CVS agree that this is a switch(4) left-over. > > > > > > > > OK? > > >

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Theo de Raadt
Klemens Nanni wrote: > On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > > On 2022/08/26 09:49, Klemens Nanni wrote: > > > grep and CVS agree that this is a switch(4) left-over. > > > > > > OK? > > > > This is exported to userland isn't it? > > No, everything is under _KERNEL

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > On 2022/08/26 09:49, Klemens Nanni wrote: > > grep and CVS agree that this is a switch(4) left-over. > > > > OK? > > This is exported to userland isn't it? No, everything is under _KERNEL.

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Vitaliy Makkoveev
On Fri, Aug 26, 2022 at 05:27:08PM +0200, Claudio Jeker wrote: > On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > > On 2022/08/26 09:49, Klemens Nanni wrote: > > > grep and CVS agree that this is a switch(4) left-over. > > > > > > OK? > > > > This is exported to userland isn't

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Claudio Jeker
On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote: > On 2022/08/26 09:49, Klemens Nanni wrote: > > grep and CVS agree that this is a switch(4) left-over. > > > > OK? > > This is exported to userland isn't it? I seariously hope not. All those caddr_t are kernel pointers. In general

Re: struct ifnet: remove unused if_switchport member

2022-08-26 Thread Stuart Henderson
On 2022/08/26 09:49, Klemens Nanni wrote: > grep and CVS agree that this is a switch(4) left-over. > > OK? This is exported to userland isn't it? If so, I think all ports using it will need a bump. > Index: if_var.h > === > RCS fi

struct ifnet: remove unused if_switchport member

2022-08-26 Thread Klemens Nanni
grep and CVS agree that this is a switch(4) left-over. OK? Index: if_var.h === RCS file: /cvs/src/sys/net/if_var.h,v retrieving revision 1.114 diff -u -p -r1.114 if_var.h --- if_var.h20 Feb 2021 04:55:52 - 1.114 +++ if_v