Re: stpecpy(): A better string copy and concatenation function

2022-02-25 Thread Alejandro Colomar (man-pages)
Hello Ali, On 25/2/22 17:22, Ali Farzanrad wrote: "Alejandro Colomar (man-pages)" wrote: char dest[SIZE]; char *end; end = &dest[SIZE - 1]; stpecpy(dest, "Hello world", end); Perfect way to introduce new hidden backdoors! Just use realloc `des

Re: stpecpy(): A better string copy and concatenation function

2022-02-25 Thread Ali Farzanrad
"Alejandro Colomar (man-pages)" wrote: >char dest[SIZE]; >char *end; > >end = &dest[SIZE - 1]; >stpecpy(dest, "Hello world", end); Perfect way to introduce new hidden backdoors! Just use realloc `dest' to a new value, but forget to update `end' pro

Re: stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Theo de Raadt
Alejandro Colomar (man-pages) wrote: > However, considering some systems don't have strl* functions, and > explicitly don't want to add them (glibc rejected strl* functions), > there it might be useful to add this function. So your position is that when a small number of people fight the emergen

Re: stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Alejandro Colomar (man-pages)
Hi Theo, On 2/13/22 23:45, Theo de Raadt wrote: > Your proposal isn't an improvement over the current situation with strl* > functions, and I don't think this is helpful. > > Alejandro Colomar (man-pages) wrote: >>Compared to other string copy and concatenation functions >>strlcat(3BS

Re: stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Theo de Raadt
Your proposal isn't an improvement over the current situation with strl* functions, and I don't think this is helpful. Alejandro Colomar (man-pages) wrote: > Hi, Todd and Theo! > > I wrote this function this week, based on strlcpy(3) and strecopy()[1], > which are the best string copy functions

stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Alejandro Colomar (man-pages)
Hi, Todd and Theo! I wrote this function this week, based on strlcpy(3) and strecopy()[1], which are the best string copy functions I've seen so far. But I came to improvements that bring one function that I think is better than both of those. I posted the function for review on codidact.com[2].