Re: split in6_selectsrc() for saner prototypes

2016-07-29 Thread Vincent Gross
On Wed, 20 Jul 2016 12:36:45 +0200 Vincent Gross wrote: > This is a completely mechanical diff to get rid of the 7-params > madness in in6_selectsrc(). > > I also apply the same treatment to in_selectsrc() for consistency. > > Ok? ... and of course I forgot to initialize a variable and broke a

Re: split in6_selectsrc() for saner prototypes

2016-07-20 Thread Martin Pieuchot
On 20/07/16(Wed) 12:36, Vincent Gross wrote: > This is a completely mechanical diff to get rid of the 7-params madness > in in6_selectsrc(). > > I also apply the same treatment to in_selectsrc() for consistency. > > Ok? The only bikesched I have is about the name. Could you keep the "in_pcb" pr

Re: split in6_selectsrc() for saner prototypes

2016-07-20 Thread Alexander Bluhm
On Wed, Jul 20, 2016 at 12:36:45PM +0200, Vincent Gross wrote: > This is a completely mechanical diff to get rid of the 7-params madness > in in6_selectsrc(). > > I also apply the same treatment to in_selectsrc() for consistency. > > Ok? OK bluhm@ > > Index: sys/netinet/in_pcb.c >

split in6_selectsrc() for saner prototypes

2016-07-20 Thread Vincent Gross
This is a completely mechanical diff to get rid of the 7-params madness in in6_selectsrc(). I also apply the same treatment to in_selectsrc() for consistency. Ok? Index: sys/netinet/in_pcb.c === RCS file: /cvs/src/sys/netinet/in_pcb