Re: snmp(1) initial UTF-8 support

2020-07-03 Thread Ingo Schwarze
Hi Martijn, sorry for the delay, now i finally looked at the function smi_displayhint_os() from the line "if (MB_CUR_MAX > 1) {" to the end of the corresponding else clause. IIUC, what that code is trying to do is iterate the input buffer "const char *buf" of length "size_t buflen". Before start

Re: snmp(1) initial UTF-8 support

2020-06-13 Thread Martijn van Duren
And of course I still had a potential buffer overflow in there... On Sat, 2020-06-13 at 09:16 +0200, Martijn van Duren wrote: > Minor change: I forgot to forward the display_hint flag to > smi_displayhint_os. Now -OQ and -Oq work as well. > > On Thu, 2020-06-11 at 21:17 +0200, Martijn van Duren w

Re: snmp(1) initial UTF-8 support

2020-06-13 Thread Martijn van Duren
Minor change: I forgot to forward the display_hint flag to smi_displayhint_os. Now -OQ and -Oq work as well. On Thu, 2020-06-11 at 21:17 +0200, Martijn van Duren wrote: > Hello Ingo, > > Thanks for looking into this. > > On Sun, 2020-05-31 at 16:32 +0200, Ingo Schwarze wrote: > > Hi Martijn, > >

Re: snmp(1) initial UTF-8 support

2020-06-11 Thread Martijn van Duren
Hello Ingo, Thanks for looking into this. On Sun, 2020-05-31 at 16:32 +0200, Ingo Schwarze wrote: > Hi Martijn, > > Martijn van Duren wrote on Tue, May 19, 2020 at 10:25:37PM +0200: > > > So according to RFC2579 an octetstring can contain UTF-8 characters if > > so described in the DISPLAY-HI

Re: snmp(1) initial UTF-8 support

2020-05-31 Thread Ingo Schwarze
Hi Martijn, Martijn van Duren wrote on Tue, May 19, 2020 at 10:25:37PM +0200: > So according to RFC2579 an octetstring can contain UTF-8 characters if > so described in the DISPLAY-HINT. One of the main consumers of this is > SnmpAdminString, which is used quite a lot. > > Now that we trimmed

snmp(1) initial UTF-8 support

2020-05-19 Thread Martijn van Duren
So according to RFC2579 an octetstring can contain UTF-8 characters if so described in the DISPLAY-HINT. One of the main consumers of this is SnmpAdminString, which is used quite a lot. Now that we trimmed a little fat from snmp's oid, I wanted to fill it up again and implemented the bare minimu