Re: sndio cleanups

2012-08-22 Thread Grumpy
> Granted, the trend seems to be that everything excepts BSDs and Linux is > dead anyways, so if it builds there, you should be fine. ;( Does Netcraft confirm this?

Re: sndio cleanups

2012-08-22 Thread Matthew Dempsky
On Wed, Aug 22, 2012 at 8:59 AM, Philip Guenther wrote: > So, you can use 'div' as the name of a object variable without > concern...if you're in a standard conforming compilation. And as long as it's not an object variable of a function pointer type that you later invoke like "div(foo)" rather t

Re: sndio cleanups

2012-08-22 Thread Philip Guenther
On Wed, Aug 22, 2012 at 2:05 AM, Marc Espie wrote: >> But does this mean we start avoiding local variables that shadow >> functions? This means that div, pause, time, and many other common >> names are to be avoided as well, doesn't it? > > Well, if you write portable code, you should. > > Some of

Re: sndio cleanups

2012-08-22 Thread Geoff Steckel
On 08/22/2012 05:05 AM, Marc Espie wrote: On Tue, Aug 21, 2012 at 09:43:25PM +0200, Alexandre Ratchov wrote: On Mon, Aug 20, 2012 at 10:10:39AM +0200, Marc Espie wrote: - prototypes for everything. Why, aren't forward declaration good enough ? Not with -Wstrict-prototypes. But does this mea

Re: sndio cleanups

2012-08-22 Thread Marc Espie
On Tue, Aug 21, 2012 at 09:43:25PM +0200, Alexandre Ratchov wrote: > On Mon, Aug 20, 2012 at 10:10:39AM +0200, Marc Espie wrote: > > since you have -Werror in your CFLAGS, sndio fails a build with > > WARNINGS=Yes... > > > > The following patch fixes things. > > - hex constants are unsigned. > >

Re: sndio cleanups

2012-08-21 Thread Alexandre Ratchov
On Mon, Aug 20, 2012 at 10:10:39AM +0200, Marc Espie wrote: > since you have -Werror in your CFLAGS, sndio fails a build with > WARNINGS=Yes... > > The following patch fixes things. > - hex constants are unsigned. OK, sure > - prototypes for everything. Why, aren't forward declaration good eno

Re: sndio cleanups

2012-08-20 Thread Marc Espie
On Mon, Aug 20, 2012 at 12:05:20PM +0200, Mark Kettenis wrote: > Must admit that it's getting a bit of a personal crusade, but I feel > quite strongly that -Wshadow in its current implementation is useless > because it whines about local variables shadowing global functions. > That really never ev

Re: sndio cleanups

2012-08-20 Thread Mark Kettenis
> Date: Mon, 20 Aug 2012 10:10:39 +0200 > From: Marc Espie > > since you have -Werror in your CFLAGS, sndio fails a build with > WARNINGS=Yes... > > The following patch fixes things. > - don't shadow libc rindex. Must admit that it's getting a bit of a personal crusade, but I feel quite strong

sndio cleanups

2012-08-20 Thread Marc Espie
since you have -Werror in your CFLAGS, sndio fails a build with WARNINGS=Yes... The following patch fixes things. - hex constants are unsigned. - prototypes for everything. - don't shadow libc rindex. Index: include/sndio.h === RCS f