Re: smtpd bug in Received: header with one recipient

2022-10-19 Thread Todd C . Miller
I took another look at this and it seems correct to me. We should not really be using tx->evp.rcpt after the it has been added to the tx->rcpts list. I plan to commit it unless there are objections. - todd

Re: smtpd bug in Received: header with one recipient

2022-10-18 Thread Chris Waddey
Ping. On Sun, Oct 09, 2022 at 08:01:01AM +0200, Martijn van Duren wrote: > Bit focused on other things atm and not familiar with this part of the > code, but some comments. > > On Sat, 2022-10-08 at 12:18 -0600, Chris Waddey wrote: >> A message with a single successful recipient but with a faile

Re: smtpd bug in Received: header with one recipient

2022-10-09 Thread Chris Waddey
On Sun, Oct 09, 2022 at 08:01:01AM +0200, Martijn van Duren wrote: > Bit focused on other things atm and not familiar with this part of the > code, but some comments. > > On Sat, 2022-10-08 at 12:18 -0600, Chris Waddey wrote: >> A message with a single successful recipient but with a failed >> rc

smtpd bug in Received: header with one recipient

2022-10-08 Thread Chris Waddey
A message with a single successful recipient but with a failed rcpt to: command afterward generates an incorrect Received: header. The following produces the bug: thief$ nc localhost 25 220 thief.private ESMTP OpenSMTPD ehlo thief.private^M 250-thief.private Hello thief.private [127.0.0.1], pleas