Re: small fix in ehci

2011-07-09 Thread Yojiro Uo
ok yuo@ -- Yojiro UO 2011/07/09 7:55 "Kenneth R Westerback" : > On Sat, Jul 09, 2011 at 06:44:26AM +0200, Eric Faurot wrote: >> So, there is actually another bug in that chunk of code. This diff >> fixes them: >> >> - Read the register from the correct location: HCSPARAMS is a >> capability regis

Re: small fix in ehci

2011-07-09 Thread Kenneth R Westerback
On Sat, Jul 09, 2011 at 06:44:26AM +0200, Eric Faurot wrote: > So, there is actually another bug in that chunk of code. This diff > fixes them: > > - Read the register from the correct location: HCSPARAMS is a > capability register. > > - Construct the resulting mask correctly by adding > pa

Re: small fix in ehci

2011-07-08 Thread Eric Faurot
So, there is actually another bug in that chunk of code. This diff fixes them: - Read the register from the correct location: HCSPARAMS is a capability register. - Construct the resulting mask correctly by adding parenthesis where needed: '|' takes precedence over '?' so currently the expr

small fix in ehci

2011-07-04 Thread Eric Faurot
actually read the register from the right place, and simplify code a bit. Index: ehci.c === RCS file: /cvs/src/sys/dev/usb/ehci.c,v retrieving revision 1.117 diff -u -r1.117 ehci.c --- ehci.c 3 Jul 2011 15:47:17 - 1.117