Re: simplify ifconfig's len_string and print_string

2020-02-25 Thread Stuart Henderson
On 2020/02/25 13:00, Stefan Sperling wrote: > On Tue, Feb 25, 2020 at 10:40:47AM +, Stuart Henderson wrote: > > On 2020/02/24 11:56, Stefan Sperling wrote: > > > These functions will compute the wrong display width for input which is > > > already a hex string. This bug doesn't trigger because

Re: simplify ifconfig's len_string and print_string

2020-02-25 Thread Stefan Sperling
On Tue, Feb 25, 2020 at 10:40:47AM +, Stuart Henderson wrote: > On 2020/02/24 11:56, Stefan Sperling wrote: > > These functions will compute the wrong display width for input which is > > already a hex string. This bug doesn't trigger because we never actually > > pass an ASCII hex string in, b

Re: simplify ifconfig's len_string and print_string

2020-02-25 Thread Stuart Henderson
On 2020/02/24 11:56, Stefan Sperling wrote: > These functions will compute the wrong display width for input which is > already a hex string. This bug doesn't trigger because we never actually > pass an ASCII hex string in, but it is still a bug. > > ASCII hex strings are printable ASCII, so there

simplify ifconfig's len_string and print_string

2020-02-24 Thread Stefan Sperling
These functions will compute the wrong display width for input which is already a hex string. This bug doesn't trigger because we never actually pass an ASCII hex string in, but it is still a bug. ASCII hex strings are printable ASCII, so there's no reason to have a special case for them. This sp