On Wed, Sep 19, 2018 at 12:46:37PM -0600, Theo de Raadt wrote:
> Not sure it matters, but I should point out a difference.
>
> Your diff makes
>
> dev_mkdb --
>
> illegal.
>
> In a POSIX world, many programs have to use getopt. Not sure if this is one.
True, I did not consider that, sorr
Not sure it matters, but I should point out a difference.
Your diff makes
dev_mkdb --
illegal.
In a POSIX world, many programs have to use getopt. Not sure if this is one.
simplify dev_mkdb:
-) no need for getopt() since there are no possible options, just check
if argc < 1
-) usage() only used once: move it to the single point of failure for
user input
-) bzero => memset, bcopy => memcpy
-) no bra
