Re: rtadvd: asprintf

2017-04-05 Thread Jeremie Courreges-Anglas
Just to make things clear, Jeremie Courreges-Anglas writes: > The last commit to this file fixed two (void)asprintf calls. Fix the > two remaining calls: depend on the ret buffer being set to NULL on I meant "don't depend on..." here, sorry for the confusion. > failure. > > ok? -- jca | PG

Re: rtadvd: asprintf

2017-04-04 Thread Theo de Raadt
> > The last commit to this file fixed two (void)asprintf calls. Fix the > > two remaining calls: depend on the ret buffer being set to NULL on > > failure. > > Personally, I would leave vltimexpire and pltimexpire initialized > to NULL and avoid those else clauses. Anything which makes the next

Re: rtadvd: asprintf

2017-04-04 Thread Todd C. Miller
On Tue, 04 Apr 2017 19:08:13 +0200, Jeremie Courreges-Anglas wrote: > The last commit to this file fixed two (void)asprintf calls. Fix the > two remaining calls: depend on the ret buffer being set to NULL on > failure. Personally, I would leave vltimexpire and pltimexpire initialized to NULL and

rtadvd: asprintf

2017-04-04 Thread Jeremie Courreges-Anglas
The last commit to this file fixed two (void)asprintf calls. Fix the two remaining calls: depend on the ret buffer being set to NULL on failure. ok? Index: dump.c === RCS file: /d/cvs/src/usr.sbin/rtadvd/dump.c,v retrieving revisi