Re: rpki-client refactor tal handling

2021-11-04 Thread Theo Buehler
On Wed, Nov 03, 2021 at 08:01:38PM +0100, Claudio Jeker wrote: > On Wed, Nov 03, 2021 at 12:41:52PM -0600, Theo de Raadt wrote: > > + size_t talid; /* covered by which TAL */ > > > > You shouldn't use size_t > > > > It is 32bit on ILP32 systems, and 64bit on I32LP64 machines, beca

Re: rpki-client refactor tal handling

2021-11-03 Thread Claudio Jeker
On Wed, Nov 03, 2021 at 12:41:52PM -0600, Theo de Raadt wrote: > + size_t talid; /* covered by which TAL */ > > You shouldn't use size_t > > It is 32bit on ILP32 systems, and 64bit on I32LP64 machines, because the > underlying definition is: > > _types.h:typedefunsigned l

Re: rpki-client refactor tal handling

2021-11-03 Thread Theo de Raadt
+ size_t talid; /* covered by which TAL */ You shouldn't use size_t It is 32bit on ILP32 systems, and 64bit on I32LP64 machines, because the underlying definition is: _types.h:typedefunsigned long __size_t; So suspect you want to use int or u_int.

rpki-client refactor tal handling

2021-11-03 Thread Claudio Jeker
This diff changes how the certs and roa track the tal that covers them. Instead of passing strings around use ids and a simple lookup table for the description. This will make it possible to add tal ids to more things. Usual test run works and the output for openbgpd and json look sane. -- :wq Cl