Re: rpki-client refactor cert.c

2022-01-18 Thread Theo Buehler
On Tue, Jan 18, 2022 at 05:39:07PM +0100, Claudio Jeker wrote: > On Tue, Jan 18, 2022 at 05:20:45PM +0100, Theo Buehler wrote: > > On Tue, Jan 18, 2022 at 04:16:17PM +0100, Claudio Jeker wrote: > > > This diff cleans up cert.c a bit. > > > > > > It removes the X509 handle from cert_parse() and ta_

Re: rpki-client refactor cert.c

2022-01-18 Thread Claudio Jeker
On Tue, Jan 18, 2022 at 05:20:45PM +0100, Theo Buehler wrote: > On Tue, Jan 18, 2022 at 04:16:17PM +0100, Claudio Jeker wrote: > > This diff cleans up cert.c a bit. > > > > It removes the X509 handle from cert_parse() and ta_parse(). Callers > > should instead use cert->x509. No need to double the

Re: rpki-client refactor cert.c

2022-01-18 Thread Theo Buehler
On Tue, Jan 18, 2022 at 04:16:17PM +0100, Claudio Jeker wrote: > This diff cleans up cert.c a bit. > > It removes the X509 handle from cert_parse() and ta_parse(). Callers > should instead use cert->x509. No need to double the work on us here. I never understood the point of this handle and I kno

rpki-client refactor cert.c

2022-01-18 Thread Claudio Jeker
This diff cleans up cert.c a bit. It removes the X509 handle from cert_parse() and ta_parse(). Callers should instead use cert->x509. No need to double the work on us here. While there switch auth_insert() to a void function. This function can not fail. Again the result is simpler code in parser.