Re: [rpki-client] Patch submission (tal.c)

2019-11-06 Thread Claudio Jeker
On Tue, Nov 05, 2019 at 01:57:09PM -0300, Alexandre Hamada wrote: > Hi Claudio. > > FYI, I've added some support for https. Not sure if this might be useful, > but here is the code for ta_parse_buffer. > > I´ve also modified tal_parse to display a warn message instead of exiting on > invalid base

Re: [rpki-client] Patch submission (tal.c)

2019-11-05 Thread Claudio Jeker
On Tue, Nov 05, 2019 at 11:01:56AM -0300, Alexandre Hamada wrote: > Hi Claudio, > > I was testing some tal files, and when it contains an https url (RFC 8630), > it generates a segmentation fault. > > Thus, I would like to suggest adding the following on tal_parse/tal_free. > > Example: > https:

Re: [rpki-client] Patch submission (tal.c)

2019-11-05 Thread Alexandre Hamada
Hi Claudio. FYI, I've added some support for https. Not sure if this might be useful, but here is the code for ta_parse_buffer. I´ve also modified tal_parse to display a warn message instead of exiting on invalid basename. Regards, Alexandre Hamada static int https_uri_parse(const char **h

[rpki-client] Patch submission (tal.c)

2019-11-05 Thread Alexandre Hamada
Hi Claudio, I was testing some tal files, and when it contains an https url (RFC 8630), it generates a segmentation fault. Thus, I would like to suggest adding the following on tal_parse/tal_free. Example: https://rir.docker/ta/ta.cer MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAoFVWio0auchdC

Re: rpki-client patch submission

2019-10-23 Thread Claudio Jeker
On Wed, Oct 23, 2019 at 08:47:25AM +0200, Theo Buehler wrote: > On Wed, Oct 23, 2019 at 08:04:26AM +0200, Claudio Jeker wrote: > > On Wed, Oct 16, 2019 at 10:47:25PM +0200, Claudio Jeker wrote: > > > On Wed, Oct 16, 2019 at 07:26:25AM -0300, Alexandre Hamada wrote: > > > > Hi Tech, > > > > I would

Re: rpki-client patch submission

2019-10-22 Thread Theo Buehler
On Wed, Oct 23, 2019 at 08:04:26AM +0200, Claudio Jeker wrote: > On Wed, Oct 16, 2019 at 10:47:25PM +0200, Claudio Jeker wrote: > > On Wed, Oct 16, 2019 at 07:26:25AM -0300, Alexandre Hamada wrote: > > > Hi Tech, > > > I would like to suggest to use UTC functions on all date/time convertions, > > >

Re: rpki-client patch submission

2019-10-22 Thread Claudio Jeker
On Wed, Oct 16, 2019 at 10:47:25PM +0200, Claudio Jeker wrote: > On Wed, Oct 16, 2019 at 07:26:25AM -0300, Alexandre Hamada wrote: > > Hi Tech, > > I would like to suggest to use UTC functions on all date/time convertions, > > to avoid some clock drift errors. > > > > Kind regards, > > Alexandre H

Re: rpki-client patch submission

2019-10-17 Thread Alexandre Hamada
Hi Claudio, I've picked up a manifest file from rsync://rpki-repository.nic.ad.jp/ap/A91A7381/131/L8CZI7Bafo8a3ZpZhO3BkyDbl0s.mft The original version returned (i'm at BRT/GMT-3) ~/tmp/rpki-client/test-mft -fv L8CZI7Bafo8a3ZpZhO3BkyDbl0s.mft test-mft: L8CZI7Bafo8a3ZpZhO3BkyDbl0s.mft: befo

Re: rpki-client patch submission

2019-10-17 Thread Claudio Jeker
On Thu, Oct 17, 2019 at 08:07:18AM -0300, Alexandre Hamada wrote: > Hi Claudio, > > Thanks for this, much appreciated. > > This is a much cleaner solution, I really liked it. > > I've tested both versions against a brand new manifest, and it is working > well. Thanks for testing. Did you manage

Re: rpki-client patch submission

2019-10-17 Thread Alexandre Hamada
Hi Claudio, Thanks for this, much appreciated. This is a much cleaner solution, I really liked it. I've tested both versions against a brand new manifest, and it is working well. One thing about this patch, at mft_parse_econtent() there are some unused variables left (this, next, now and bu

Re: rpki-client patch submission

2019-10-16 Thread Claudio Jeker
On Wed, Oct 16, 2019 at 07:26:25AM -0300, Alexandre Hamada wrote: > Hi Tech, > I would like to suggest to use UTC functions on all date/time convertions, > to avoid some clock drift errors. > > Kind regards, > Alexandre Hamada > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-clien

Re: rpki-client patch submission

2019-10-16 Thread Claudio Jeker
On Wed, Oct 16, 2019 at 07:26:25AM -0300, Alexandre Hamada wrote: > Hi Tech, > I would like to suggest to use UTC functions on all date/time convertions, > to avoid some clock drift errors. I came to the conclusion that more is needed in this function. Converting time using ASN1_GENERALIZEDTIME_pr

rpki-client patch submission

2019-10-16 Thread Alexandre Hamada
Hi Tech, I would like to suggest to use UTC functions on all date/time convertions, to avoid some clock drift errors. Kind regards, Alexandre Hamada https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/9.patch From a463f8cb23375f15b74eff49a06e8934423e3dbf Mon Sep 17 00:00:

Re: rpki-client patch submission

2019-10-03 Thread Alexandre Hamada
Hi Claudio, thanks for answering promptly, much appreciated. Kind regards, Alexandre Hamada On 02/10/2019 17:17, Claudio Jeker wrote: On Wed, Oct 02, 2019 at 03:41:06PM -0300, Alexandre Hamada wrote: Hi Tech, I've found a missing initialization at ip.c (rpki-client project), and I would like

Re: rpki-client patch submission

2019-10-02 Thread Claudio Jeker
On Wed, Oct 02, 2019 at 03:41:06PM -0300, Alexandre Hamada wrote: > Hi Tech, > > I've found a missing initialization at ip.c (rpki-client project), and I > would like to share this patch with the repository maintainer. > > Kind regards, > Alexandre Hamada Thanks for this patch. The memset() of a

rpki-client patch submission

2019-10-02 Thread Alexandre Hamada
Hi Tech, I've found a missing initialization at ip.c (rpki-client project), and I would like to share this patch with the repository maintainer. Kind regards, Alexandre Hamada https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/8.patch From e74a5c02fbab9172dd856fc7214be4