Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Theo de Raadt
Claudio Jeker wrote: > On Thu, Apr 16, 2020 at 09:45:45AM -0600, Theo de Raadt wrote: > > I don't understand the point of any of this cleanup. The process > > is dying and none of these things maintain external state. > > > > I'm going to call it what it is: stylistically stupid and rigid. > >

Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Theo de Raadt
Claudio Jeker wrote: > On Thu, Apr 16, 2020 at 09:45:45AM -0600, Theo de Raadt wrote: > > I don't understand the point of any of this cleanup. The process > > is dying and none of these things maintain external state. > > > > I'm going to call it what it is: stylistically stupid and rigid. > >

Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Claudio Jeker
On Thu, Apr 16, 2020 at 09:45:45AM -0600, Theo de Raadt wrote: > I don't understand the point of any of this cleanup. The process > is dying and none of these things maintain external state. > > I'm going to call it what it is: stylistically stupid and rigid. > > Why? Because it would mean ever

Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Theo de Raadt
I don't understand the point of any of this cleanup. The process is dying and none of these things maintain external state. I'm going to call it what it is: stylistically stupid and rigid. Why? Because it would mean every call to errx() in the program is wrong because they don't attempt this, a

rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Claudio Jeker
ERR_remove_state(0) is deprecated use the new api ERR_remove_thread_state(NULL) instead. -- :wq Claudio Index: main.c === RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v retrieving revision 1.61 diff -u -p -r1.61 main.c --- main.c