Re: rpki-client, don't double fail on getaddrinfo errors

2021-03-30 Thread Theo Buehler
On Tue, Mar 30, 2021 at 05:51:38PM +0200, Claudio Jeker wrote: > On Tue, Mar 30, 2021 at 05:45:39PM +0200, Theo Buehler wrote: > > On Tue, Mar 30, 2021 at 05:30:19PM +0200, Claudio Jeker wrote: > > > Found the hard way. http_new() call http_free() if http_resolv() failes. > > > http_free() call htt

Re: rpki-client, don't double fail on getaddrinfo errors

2021-03-30 Thread Claudio Jeker
On Tue, Mar 30, 2021 at 05:45:39PM +0200, Theo Buehler wrote: > On Tue, Mar 30, 2021 at 05:30:19PM +0200, Claudio Jeker wrote: > > Found the hard way. http_new() call http_free() if http_resolv() failes. > > http_free() call http_fail() in that case since the state is not > > STATE_DONE. In the mai

Re: rpki-client, don't double fail on getaddrinfo errors

2021-03-30 Thread Theo Buehler
On Tue, Mar 30, 2021 at 05:30:19PM +0200, Claudio Jeker wrote: > Found the hard way. http_new() call http_free() if http_resolv() failes. > http_free() call http_fail() in that case since the state is not > STATE_DONE. In the main poll loop another http_fail() call is made. This > results in bad ba

rpki-client, don't double fail on getaddrinfo errors

2021-03-30 Thread Claudio Jeker
Found the hard way. http_new() call http_free() if http_resolv() failes. http_free() call http_fail() in that case since the state is not STATE_DONE. In the main poll loop another http_fail() call is made. This results in bad bad things. -- :wq Claudio Index: http.c =