Re: rpc: misc. time-related cleanup

2017-12-27 Thread Jeremie Courreges-Anglas
On Wed, Dec 27 2017, "Theo de Raadt" wrote: >> > Since timespecs also use tv_* prefixes, a hint about the other sub-second >> > field is being lost, also, sometimes the clearing of the sub-second field >> > isn't in the same place it is missing. >> >> What do you have in mind when you say "sub-se

Re: rpc: misc. time-related cleanup

2017-12-27 Thread Theo de Raadt
> > Since timespecs also use tv_* prefixes, a hint about the other sub-second > > field is being lost, also, sometimes the clearing of the sub-second field > > isn't in the same place it is missing. > > What do you have in mind when you say "sub-second initialization"? The > idea is to use time(3

Re: rpc: misc. time-related cleanup

2017-12-27 Thread Jeremie Courreges-Anglas
On Wed, Dec 27 2017, "Theo de Raadt" wrote: >> > I really don't get the cruscade agains gettimeofday(). Despite what >> > POSIX may say, it is not going away. And what you're proposing isn't >> > really an optimization. As far as I'm concerned this is just >> > (unwanted) churn. >> >> I don't

Re: rpc: misc. time-related cleanup

2017-12-27 Thread Theo de Raadt
> > I really don't get the cruscade agains gettimeofday(). Despite what > > POSIX may say, it is not going away. And what you're proposing isn't > > really an optimization. As far as I'm concerned this is just > > (unwanted) churn. > > I don't think there's a crusade here; time(3) gives us shor

Re: rpc: misc. time-related cleanup

2017-12-27 Thread Jeremie Courreges-Anglas
On Wed, Dec 27 2017, Mark Kettenis wrote: >> Date: Wed, 27 Dec 2017 08:52:28 -0600 >> From: Scott Cheloha >> >> The timevals in clnt_tcp.c and clnt_udp.c are assigned and never used. >> >> The timevals in auth_unix.c are only used for the .tv_sec field, so >> we can just initialize .aup_time wi

Re: rpc: misc. time-related cleanup

2017-12-27 Thread Mark Kettenis
> Date: Wed, 27 Dec 2017 08:52:28 -0600 > From: Scott Cheloha > > The timevals in clnt_tcp.c and clnt_udp.c are assigned and never used. > > The timevals in auth_unix.c are only used for the .tv_sec field, so > we can just initialize .aup_time with time(3). > > ok? I really don't get the crusc

rpc: misc. time-related cleanup

2017-12-27 Thread Scott Cheloha
The timevals in clnt_tcp.c and clnt_udp.c are assigned and never used. The timevals in auth_unix.c are only used for the .tv_sec field, so we can just initialize .aup_time with time(3). ok? -- Scott Cheloha Index: lib/libc/rpc/auth_unix.c