Re: default route and route socket filter on priority

2018-02-21 Thread Martin Pieuchot
On 19/02/18(Mon) 14:00, Sebastian Benoit wrote: > Martin Pieuchot(m...@openbsd.org) on 2018.02.12 15:23:45 +0100: > > On 12/02/18(Mon) 12:02, Sebastian Benoit wrote: > > > routefilter currently filters the default route, > > > if it's priority is higher than the filter prio. > > > > Then why not c

Re: default route and route socket filter on priority

2018-02-19 Thread Sebastian Benoit
Martin Pieuchot(m...@openbsd.org) on 2018.02.12 15:23:45 +0100: > On 12/02/18(Mon) 12:02, Sebastian Benoit wrote: > > routefilter currently filters the default route, > > if it's priority is higher than the filter prio. > > Then why not change the priority of the default route? > > > This might n

Re: default route and route socket filter on priority

2018-02-12 Thread Stuart Henderson
On 2018/02/12 15:23, Martin Pieuchot wrote: > On 12/02/18(Mon) 12:02, Sebastian Benoit wrote: > > routefilter currently filters the default route, > > if it's priority is higher than the filter prio. > > Then why not change the priority of the default route? On a standard machine this is already

Re: default route and route socket filter on priority

2018-02-12 Thread Martin Pieuchot
On 12/02/18(Mon) 12:02, Sebastian Benoit wrote: > routefilter currently filters the default route, > if it's priority is higher than the filter prio. Then why not change the priority of the default route? > This might not be a good idea - for example you might want to > redistribute a default rou

default route and route socket filter on priority

2018-02-12 Thread Sebastian Benoit
routefilter currently filters the default route, if it's priority is higher than the filter prio. This might not be a good idea - for example you might want to redistribute a default route into ospf, for that you need it in the routing table but it is configured with a low priority (high value) as

Re: ospfd (route socket filter on priority)

2018-02-10 Thread Claudio Jeker
On Sun, Feb 11, 2018 at 02:17:38AM +0100, Sebastian Benoit wrote: > > Hi, > > here is the ospfd part again, now the socket option is set on reload as > well. > > ok? > > (benno_route_priofilter_2_ospfd.diff) > > diff --git usr.sbin/ospfd/kroute.c usr.sbin/ospfd/kroute.c > index 17febefbdcb..4f

Re: route socket filter on priority

2018-02-10 Thread Claudio
On Sun, Feb 11, 2018 at 02:14:32AM +0100, Sebastian Benoit wrote: > Stuart Henderson(s...@spacehopper.org) on 2018.02.10 10:41:11 +: > > This comment needs fixing or removing, otherwise ok. > > Feel free to use this accompanying manpage diff. > > Hi sthen, thanks > > updated diff,this is only

ospfd (route socket filter on priority)

2018-02-10 Thread Sebastian Benoit
Hi, here is the ospfd part again, now the socket option is set on reload as well. ok? (benno_route_priofilter_2_ospfd.diff) diff --git usr.sbin/ospfd/kroute.c usr.sbin/ospfd/kroute.c index 17febefbdcb..4f6dc933a42 100644 --- usr.sbin/ospfd/kroute.c +++ usr.sbin/ospfd/kroute.c @@ -127,10 +127,1

Re: route socket filter on priority

2018-02-10 Thread Sebastian Benoit
Stuart Henderson(s...@spacehopper.org) on 2018.02.10 10:41:11 +: > This comment needs fixing or removing, otherwise ok. > Feel free to use this accompanying manpage diff. Hi sthen, thanks updated diff,this is only the kernel part + manpage. I added the RTP constants to the manpage, as all the

Re: route socket filter on priority

2018-02-10 Thread Stuart Henderson
On 2018/02/10 10:12, Sebastian Benoit wrote: > > > - add ROUTE_PRIOFILTER > - it has one argument that is interpreted as a route priority > - all route updates with prio lower or equal will pass the filter, > all with higher priority value will be filtered. > - example use in ospfd > > comment

Re: route socket filter on priority

2018-02-10 Thread Tom Smyth
Nice feature lots of real world use cases. On 10 Feb 2018 9:19 AM, "Sebastian Benoit" wrote: > > > - add ROUTE_PRIOFILTER > - it has one argument that is interpreted as a route priority > - all route updates with prio lower or equal will pass the filter, > all with higher priority value will

route socket filter on priority

2018-02-10 Thread Sebastian Benoit
- add ROUTE_PRIOFILTER - it has one argument that is interpreted as a route priority - all route updates with prio lower or equal will pass the filter, all with higher priority value will be filtered. - example use in ospfd comments/oks? (benno_ospfd_route_priofilter_1.diff) diff --git sys/n