Re: resolvd: write nameservers in expected order

2022-11-05 Thread Klemens Nanni
On Sat, Nov 05, 2022 at 05:40:49AM -0600, Theo de Raadt wrote: > + if (mergesort(learning, ASR_MAXNS, sizeof(learning[0]), cmp) == -1) > + lerr(1, "mergesort"); > > So at runtime if mergesort() fails to allocate memory, the program will > simply exit? Ah no, that should just s

Re: resolvd: write nameservers in expected order

2022-11-05 Thread Theo de Raadt
+ if (mergesort(learning, ASR_MAXNS, sizeof(learning[0]), cmp) == -1) + lerr(1, "mergesort"); So at runtime if mergesort() fails to allocate memory, the program will simply exit?

Re: resolvd: write nameservers in expected order

2022-11-05 Thread Klemens Nanni
On Thu, Nov 03, 2022 at 10:27:53PM +, Klemens Nanni wrote: > RFC 2132 "DHCP Options and BOOTP Vendor Extensions" > 3.8. Domain Name Server Option says: > >The domain name server option specifies a list of Domain Name System >(STD 13, RFC 1035 [8]) name servers available to the client.

Re: resolvd: write nameservers in expected order

2022-11-03 Thread Theo de Raadt
If you do not sort the, you cannot remove duplicates.

resolvd: write nameservers in expected order

2022-11-03 Thread Klemens Nanni
RFC 2132 "DHCP Options and BOOTP Vendor Extensions" 3.8. Domain Name Server Option says: The domain name server option specifies a list of Domain Name System (STD 13, RFC 1035 [8]) name servers available to the client. Servers SHOULD be listed in order of preference. I'm on a wifi with