Re: reorder_kernel: Use variable and shorter logic for NFS check

2022-11-07 Thread Klemens Nanni
On Mon, Nov 07, 2022 at 04:59:31PM +0100, Theo Buehler wrote: > > NB: I was certain that we use a similar skip-if-on-NFS idiom elsewhere > > in our tree, but couldn't find it, so I probably misremember things. > > Do you think of the "Don't kill NFS" check in /etc/rc? No, specifically using `

Re: reorder_kernel: Use variable and shorter logic for NFS check

2022-11-07 Thread Theo Buehler
On Mon, Nov 07, 2022 at 02:21:53PM +, Klemens Nanni wrote: > No need to hardcode a parent path if we can reuse an existing variable > for the specific path that is in being used. > > Negate the file system type in df(1) so the `|| exit 1' can be dropped > in favour of the errexit option, as is

reorder_kernel: Use variable and shorter logic for NFS check

2022-11-07 Thread Klemens Nanni
No need to hardcode a parent path if we can reuse an existing variable for the specific path that is in being used. Negate the file system type in df(1) so the `|| exit 1' can be dropped in favour of the errexit option, as is done for all else in there. (I should've proposed it like this back in 2