Re: remove unused rtentry parameter from rtm_addr()

2018-04-23 Thread Claudio Jeker
On Mon, Apr 23, 2018 at 04:38:12PM +0200, Florian Obser wrote: > any objections? otherwise I'll commit it with OK benno, kn Not from me. OK claudio@ > On Thu, Apr 19, 2018 at 08:08:45AM +0200, Florian Obser wrote: > > On Wed, Apr 18, 2018 at 11:31:02PM +0200, Alexander Bluhm wrote: > > > On Wed,

Re: remove unused rtentry parameter from rtm_addr()

2018-04-23 Thread Florian Obser
any objections? otherwise I'll commit it with OK benno, kn On Thu, Apr 19, 2018 at 08:08:45AM +0200, Florian Obser wrote: > On Wed, Apr 18, 2018 at 11:31:02PM +0200, Alexander Bluhm wrote: > > On Wed, Apr 18, 2018 at 05:03:04PM +0200, Florian Obser wrote: > > > @@ -1158,9 +1158,9 @@ rt_ifa_del(str

Re: remove unused rtentry parameter from rtm_addr()

2018-04-18 Thread Florian Obser
On Wed, Apr 18, 2018 at 11:31:02PM +0200, Alexander Bluhm wrote: > On Wed, Apr 18, 2018 at 05:03:04PM +0200, Florian Obser wrote: > > @@ -1158,9 +1158,9 @@ rt_ifa_del(struct ifaddr *ifa, int flags, struct > > sockaddr *dst) > > error = rtrequest_delete(&info, prio, ifp, &rt, rtableid); > >

Re: remove unused rtentry parameter from rtm_addr()

2018-04-18 Thread Alexander Bluhm
On Wed, Apr 18, 2018 at 05:03:04PM +0200, Florian Obser wrote: > @@ -1158,9 +1158,9 @@ rt_ifa_del(struct ifaddr *ifa, int flags, struct > sockaddr *dst) > error = rtrequest_delete(&info, prio, ifp, &rt, rtableid); > if (error == 0) { > rtm_send(rt, RTM_DELETE, 0, rtableid

Re: remove unused rtentry parameter from rtm_addr()

2018-04-18 Thread Klemens Nanni
On Wed, Apr 18, 2018 at 05:03:04PM +0200, Florian Obser wrote: > some dude commited it like this in '95. It used to be used until mpi@ started passing ifa: "Pass the configured ``ifa'' to rt_sendaddrmsg() instead of getting it via ``rt->rt_ifa'' later" http://cvsweb.openbsd.org/cg

remove unused rtentry parameter from rtm_addr()

2018-04-18 Thread Florian Obser
some dude commited it like this in '95. I came accress it because I want to use it in a place where I don't have a rtentry allocated already. OK? diff --git net/route.c net/route.c index 30c8def301d..a0c5738d831 100644 --- net/route.c +++ net/route.c @@ -1103,7 +1103,7 @@ rt_ifa_add(struct ifadd