Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-16 Thread Stuart Henderson
On 2021/02/16 20:12, Franz Bettag wrote: > My point, the protocol after HTTP 1.0 encourages keep-alives anyway. > Close is only default in 1.0 so basically you wouldn’t have lingering > dead sockets on your server. If you want a full featured HTTP implementation then perhaps relayd is not for you

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-16 Thread Stuart Henderson
Clearly the current behaviour with two Connection headers is wrong and this may be a correct diff, but the description accompanying it only considers "how does this fix the problem seen" rather than "what are the implications of this, does it do anything bad?". I'm only making very minimal use of

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-16 Thread Franz Bettag
At least someone besides me cares about correct protocols in base daemons :] Sent from my iPhone > On 14 Feb 2021, at 12:06, Marcus MERIGHI wrote: > > Another month has passed, another friendly bump... > > patch against -current attached, for convenience... > > Marcus > > Index: relay_http.

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-14 Thread Marcus MERIGHI
Another month has passed, another friendly bump... patch against -current attached, for convenience... Marcus Index: relay_http.c === RCS file: /cvs/src/usr.sbin/relayd/relay_http.c,v retrieving revision 1.80 diff -u -p -u -r1.80 re

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-01-04 Thread Marcus MERIGHI
One month has passed, this is just a friendly ping... Marcus mcmer-open...@tor.at (Marcus MERIGHI), 2020.12.04 (Fri) 14:18 (CET): > This patch wasn't commited and not discussed (publicly). > > It lets me use relayd as a front-end to the mattermost-server. > > @franz: Thank you! > > fr...@bett

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2020-12-04 Thread Franz Bettag
thanks for bringing it up again, i always have to patch multiple relayds after upgrades. -.- Sent from my iPad > On 4. Dec 2020, at 14:18, Marcus MERIGHI wrote: > > Hello! > > This patch wasn't commited and not discussed (publicly). > > It lets me use relayd as a front-end to the mattermos

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2020-12-04 Thread Marcus MERIGHI
Hello! This patch wasn't commited and not discussed (publicly). It lets me use relayd as a front-end to the mattermost-server. Just a friendly reminder... @franz: Thank you! Marcus fr...@bett.ag (Franz Bettag), 2020.03.04 (Wed) 17:52 (CET): > After migrating my home setup from nginx reverse

[PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2020-03-04 Thread Franz Bettag
After migrating my home setup from nginx reverse proxying to relayd, i noticed my iOS devices having issues connecting through Websockets. After debugging, i noticed that relayd adds the "Connection: close" regardless of upgrade being requested. This issue is also reported on a blog-post using re

Re: relayd websocket

2019-05-08 Thread Sebastian Benoit
ok benno@ Reyk Floeter(r...@openbsd.org) on 2019.05.08 20:35:46 +0200: > On Wed, May 08, 2019 at 07:07:43PM +0200, Reyk Floeter wrote: > > On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: > > > On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > > > > Rivo Nurges(riv

Re: relayd websocket

2019-05-08 Thread Rivo Nurges
Hi! Seems to work fine. Rivo On 2019-05-08 21:37, Reyk Floeter wrote: > On Wed, May 08, 2019 at 07:07:43PM +0200, Reyk Floeter wrote: >> On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: >>> On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: Rivo Nurges(rivo.nur..

Re: relayd websocket

2019-05-08 Thread Reyk Floeter
On Wed, May 08, 2019 at 07:07:43PM +0200, Reyk Floeter wrote: > On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: > > On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > > > Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > > > > Hi! > > > > > > > > On 3/

Re: relayd websocket

2019-05-08 Thread Reyk Floeter
On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: > On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > > Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > > > Hi! > > > > > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > > > I guess that this would need s

Re: relayd websocket

2019-05-08 Thread Reyk Floeter
On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > > Hi! > > > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > > I guess that this would need strcasestr() instead of strcasecmp(), since > > > you > > > are looking fo

Re: relayd websocket

2019-05-08 Thread Rivo Nurges
Hi! Anyone? Rivo On 2019-03-12 21:50, Rivo Nurges wrote: > Hi! > > Bump... > > Rivo > > On 3/6/19 10:57 PM, Rivo Nurges wrote: >> Hi! >> >> >> On 3/6/19 10:20 PM, Rivo Nurges wrote: >>> On 3/6/19 6:36 PM, Sebastian Benoit wrote: > Does something like this make sense? i think the

Re: relayd websocket

2019-03-12 Thread Rivo Nurges
Hi! Bump... Rivo On 3/6/19 10:57 PM, Rivo Nurges wrote: > Hi! > > > On 3/6/19 10:20 PM, Rivo Nurges wrote: >> On 3/6/19 6:36 PM, Sebastian Benoit wrote: Does something like this make sense? >>> >>> i think the seperator list needs to include '\t' >>> because https://tools.ietf.org/html/rf

Re: relayd websocket

2019-03-06 Thread Rivo Nurges
Hi! On 3/6/19 10:20 PM, Rivo Nurges wrote: > On 3/6/19 6:36 PM, Sebastian Benoit wrote: >>> Does something like this make sense? >> >> i think the seperator list needs to include '\t' >> because https://tools.ietf.org/html/rfc7230#appendix-B includes HTAB. >> >> And i dont think you can mix "," w

Re: relayd websocket

2019-03-06 Thread Rivo Nurges
On 3/6/19 6:36 PM, Sebastian Benoit wrote: >> Does something like this make sense? > > i think the seperator list needs to include '\t' > because https://tools.ietf.org/html/rfc7230#appendix-B includes HTAB. > > And i dont think you can mix "," with " \t" seperators, > because otherwise "Foo Upgr

Re: relayd websocket

2019-03-06 Thread Sebastian Benoit
Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > Hi! > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > I guess that this would need strcasestr() instead of strcasecmp(), since you > > are looking for the substring "Upgrade" in value. Maybe more is needed if > > we want to be sure th

Re: relayd websocket

2019-03-05 Thread Rivo Nurges
Hi! On 3/5/19 10:36 PM, Claudio Jeker wrote: > I guess that this would need strcasestr() instead of strcasecmp(), since you > are looking for the substring "Upgrade" in value. Maybe more is needed if > we want to be sure that 'Connection: Upgrade-maybe' does not match. You are correct about strca

Re: relayd websocket

2019-03-05 Thread Claudio Jeker
On Tue, Mar 05, 2019 at 04:21:30PM +, Rivo Nurges wrote: > Hi! > > RFC 6455 4.2.1 states: > 4. A |Connection| header field that *includes* the token "Upgrade", > treated as an ASCII case-insensitive value. > > In my test case Firefox sends: Connection: keep-alive, Upgrade > > Relayd

relayd websocket

2019-03-05 Thread Rivo Nurges
Hi! RFC 6455 4.2.1 states: 4. A |Connection| header field that *includes* the token "Upgrade", treated as an ASCII case-insensitive value. In my test case Firefox sends: Connection: keep-alive, Upgrade Relayd currently expects Connection to equal Upgrade, not include Upgrade. I haven't