Re: relayd: uninitialized errstr

2022-11-09 Thread Theo Buehler
On Thu, Nov 10, 2022 at 01:35:09AM +0100, Moritz Buhl wrote: > On Thu, Nov 10, 2022 at 01:29:13AM +0100, Theo Buehler wrote: > > On Thu, Nov 10, 2022 at 01:10:51AM +0100, Moritz Buhl wrote: > > > errstr is never set but fail does: > > > RSA_meth_free(rsae_method); > > > fatalx("%s:

Re: relayd: uninitialized errstr

2022-11-09 Thread Moritz Buhl
On Thu, Nov 10, 2022 at 01:29:13AM +0100, Theo Buehler wrote: > On Thu, Nov 10, 2022 at 01:10:51AM +0100, Moritz Buhl wrote: > > errstr is never set but fail does: > > RSA_meth_free(rsae_method); > > fatalx("%s: %s", __func__, errstr); > > Found by codechecker. > > > > OK? > > Nee

Re: relayd: uninitialized errstr

2022-11-09 Thread Theo Buehler
On Thu, Nov 10, 2022 at 01:10:51AM +0100, Moritz Buhl wrote: > errstr is never set but fail does: > RSA_meth_free(rsae_method); > fatalx("%s: %s", __func__, errstr); > Found by codechecker. > > OK? Needs more braces > mbuhl > > Index: ca.c > =

relayd: uninitialized errstr

2022-11-09 Thread Moritz Buhl
errstr is never set but fail does: RSA_meth_free(rsae_method); fatalx("%s: %s", __func__, errstr); Found by codechecker. OK? mbuhl Index: ca.c === RCS file: /cvs/src/usr.sbin/relayd/ca.c,v retrieving revision 1.39 dif