Re: recursive splsoftnet()

2017-01-02 Thread Mike Belopuhov
On 2 January 2017 at 12:39, Martin Pieuchot wrote: > Kill two simple recursive splsoftnet(). > > - pr_usrreq() functions are always called under NET_LOCK(). > - tcp_ident() is called by tcp_sysctl() only which asserts for the NET_LOCK() > > ok? > OK

recursive splsoftnet()

2017-01-02 Thread Martin Pieuchot
Kill two simple recursive splsoftnet(). - pr_usrreq() functions are always called under NET_LOCK(). - tcp_ident() is called by tcp_sysctl() only which asserts for the NET_LOCK() ok? Index: netinet/ip_gre.c === RCS file: /cvs/src

Re: Recursive splsoftnet() in in6_ifattach_linklocal()

2016-12-29 Thread Alexander Bluhm
On Thu, Dec 29, 2016 at 09:15:54AM +0100, Martin Pieuchot wrote: > Get rid of them, ok? OK bluhm@ > > Index: netinet6/in6_ifattach.c > === > RCS file: /cvs/src/sys/netinet6/in6_ifattach.c,v > retrieving revision 1.100 > diff -u -p -

Recursive splsoftnet() in in6_ifattach_linklocal()

2016-12-29 Thread Martin Pieuchot
Get rid of them, ok? Index: netinet6/in6_ifattach.c === RCS file: /cvs/src/sys/netinet6/in6_ifattach.c,v retrieving revision 1.100 diff -u -p -r1.100 in6_ifattach.c --- netinet6/in6_ifattach.c 30 Jun 2016 08:19:03 - 1.100

Re: recursive splsoftnet() in ND6

2016-11-28 Thread Alexander Bluhm
On Mon, Nov 28, 2016 at 12:31:39PM +0100, Martin Pieuchot wrote: > This kill multiple recursive splsoftnet(), ok? OK bluhm@ > > Index: netinet6/nd6.h > === > RCS file: /cvs/src/sys/netinet6/nd6.h,v > retrie

recursive splsoftnet() in ND6

2016-11-28 Thread Martin Pieuchot
This kill multiple recursive splsoftnet(), ok? Index: netinet6/nd6.h === RCS file: /cvs/src/sys/netinet6/nd6.h,v retrieving revision 1.64 diff -u -p -r1.64 nd6.h --- netinet6/nd6.h 21 Nov 2016 10:52:08 - 1.64

Re: tcp_input.c: recursive splsoftnet()

2016-11-16 Thread Alexander Bluhm
On Wed, Nov 16, 2016 at 09:58:00AM +0100, Martin Pieuchot wrote: > On 15/11/16(Tue) 16:36, Alexander Bluhm wrote: > > [...] > > You are a bit inconsistent wether you remove the {} from one line > > if blocks. > > That should fix my inconsistencies. OK bluhm@ > > Index: netinet/tcp_input.c > ===

Re: tcp_input.c: recursive splsoftnet()

2016-11-16 Thread Martin Pieuchot
On 15/11/16(Tue) 16:36, Alexander Bluhm wrote: > [...] > You are a bit inconsistent wether you remove the {} from one line > if blocks. That should fix my inconsistencies. Index: netinet/tcp_input.c === RCS file: /cvs/src/sys/netinet

Re: pf_ioctl.c: recursive splsoftnet()

2016-11-15 Thread Alexander Bluhm
On Tue, Nov 15, 2016 at 03:41:48PM +0100, Martin Pieuchot wrote: > Kill a bunch of recursive splsoftnet()s. pf_ioctl() already call > splsoftnet() and for the functions that are also called from pf_test() > the spl level is already IPL_SOFTNET. > > ok? OK bluhm@ > &g

Re: tcp_input.c: recursive splsoftnet()

2016-11-15 Thread Alexander Bluhm
On Tue, Nov 15, 2016 at 04:03:40PM +0100, Martin Pieuchot wrote: > Assert that the sync cache functions are always called under the correct > IPL. > > This kill some more recursive splsoftnet(). > > While here keep local declarations local, this makes my life easier. > Th

tcp_input.c: recursive splsoftnet()

2016-11-15 Thread Martin Pieuchot
Assert that the sync cache functions are always called under the correct IPL. This kill some more recursive splsoftnet(). While here keep local declarations local, this makes my life easier. This way I know I don't need to grep the whole tree to look where the functions are called.

pf_ioctl.c: recursive splsoftnet()

2016-11-15 Thread Martin Pieuchot
Kill a bunch of recursive splsoftnet()s. pf_ioctl() already call splsoftnet() and for the functions that are also called from pf_test() the spl level is already IPL_SOFTNET. ok? Index: net/pf_if.c === RCS file: /cvs/src/sys/net

Re: Recursive splsoftnet() in PMTU

2016-11-08 Thread Alexander Bluhm
On Mon, Nov 07, 2016 at 10:36:26AM +0100, Martin Pieuchot wrote: > Timers configured with rt_timer_add(9) are always run under splsoftnet() > so no need to take it recursively. > > ok? OK bluhm@ > > Index: netinet/ip_icmp.c > === >

Recursive splsoftnet() in PMTU

2016-11-07 Thread Martin Pieuchot
Timers configured with rt_timer_add(9) are always run under splsoftnet() so no need to take it recursively. ok? Index: netinet/ip_icmp.c === RCS file: /cvs/src/sys/netinet/ip_icmp.c,v retrieving revision 1.152 diff -u -p -r1.152 ip_i