Re: rdistd: quiet compiler warnings

2016-03-30 Thread Todd C. Miller
On Wed, 30 Mar 2016 14:29:05 -0600, Theo de Raadt wrote: > > /usr/src/usr.bin/rdistd/server.c:845: warning: zero-length printf format st > ring > > defs.h:void error(const char *, ...) __attribute__((format (printf, 1, 2))); > > That seems to be the source of this warning. That function is not

Re: rdistd: quiet compiler warnings

2016-03-30 Thread Theo de Raadt
> /usr/src/usr.bin/rdistd/server.c:845: warning: zero-length printf format > string defs.h:void error(const char *, ...) __attribute__((format (printf, 1, 2))); That seems to be the source of this warning. That function is not printf-like, in that it produces an implicit newline... Shrug, it i

rdistd: quiet compiler warnings

2016-03-30 Thread Todd C. Miller
This fixed the following warnings: /usr/src/usr.bin/rdistd/server.c:845: warning: zero-length printf format string /usr/src/usr.bin/rdistd/server.c:1150: warning: zero-length printf format string The error() function already supports passing a NULL format string. This diff allows message() to han