Re: properly inject UDP header for udpencap over IPv6

2016-02-28 Thread Mike Belopuhov
On Fri, Feb 26, 2016 at 21:55 +0100, Patrick Wildt wrote: > On Fri, Feb 26, 2016 at 08:25:02PM +0100, Alexander Bluhm wrote: > > On Fri, Feb 26, 2016 at 04:56:49PM +0100, Mike Belopuhov wrote: > > > I think your revised diff should be committed. Any objections? > > > > OK bluhm@ > > > > > >

Re: properly inject UDP header for udpencap over IPv6

2016-02-26 Thread Alexander Bluhm
On Fri, Feb 26, 2016 at 09:55:35PM +0100, Patrick Wildt wrote: > bluhm proposed to add M_UDP_CSUM_OUT to the mbuf csum flags. I just > tried his proposal and it looks like the following diff works. Yes, also OK bluhm@ for this. > diff --git sys/netinet/ipsec_output.c sys/netinet/ipsec_output.c >

Re: properly inject UDP header for udpencap over IPv6

2016-02-26 Thread Patrick Wildt
On Fri, Feb 26, 2016 at 08:25:02PM +0100, Alexander Bluhm wrote: > On Fri, Feb 26, 2016 at 04:56:49PM +0100, Mike Belopuhov wrote: > > I think your revised diff should be committed. Any objections? > > OK bluhm@ > > > > uh->uh_sum = 0; > > > +#ifdef INET6 > > > + if (tdb->tdb_d

Re: properly inject UDP header for udpencap over IPv6

2016-02-26 Thread Alexander Bluhm
On Fri, Feb 26, 2016 at 04:56:49PM +0100, Mike Belopuhov wrote: > I think your revised diff should be committed. Any objections? OK bluhm@ > > uh->uh_sum = 0; > > +#ifdef INET6 > > + if (tdb->tdb_dst.sa.sa_family == AF_INET6) > > + uh->uh_sum = in6_cksum(m

Re: properly inject UDP header for udpencap over IPv6

2016-02-26 Thread Mike Belopuhov
Hi Patrick, I think your revised diff should be committed. Any objections? On Fri, Feb 26, 2016 at 15:12 +0100, Patrick Wildt wrote: > Bump with updated diff, now that tree is unlocked again. > > Patrick > > diff --git sys/netinet/ipsec_output.c sys/netinet/ipsec_output.c > index 91c319f..18a3

Re: properly inject UDP header for udpencap over IPv6

2016-02-26 Thread Patrick Wildt
Bump with updated diff, now that tree is unlocked again. Patrick diff --git sys/netinet/ipsec_output.c sys/netinet/ipsec_output.c index 91c319f..18a3f57 100644 --- sys/netinet/ipsec_output.c +++ sys/netinet/ipsec_output.c @@ -375,13 +375,30 @@ ipsp_process_done(struct mbuf *m, struct tdb *tdb)

properly inject UDP header for udpencap over IPv6

2016-02-21 Thread Patrick Wildt
Hi, debugging my setup at home I realized that NAT-T on IPv6 is broken. I know that NAT in IPv6 sucks, but apparently my dsl modem does not reliably forward ESP packets, so I use NAT-T instead... *sigh* Moving that setup from IPv4 to IPv6 I noticed that pf was blocking outgoing packets and its sr