Re: prevent re-upgrade in powerpc64 boot loader

2023-10-08 Thread Klemens Nanni
9/23/23 14:11, Mark Kettenis пишет: >> Date: Thu, 21 Sep 2023 22:30:01 + >> From: Klemens Nanni >> >> In comparison to MI boot which only cares about /bsd.upgrade's x bit, >> powerpc64 rdboot just wants a regular file. >> >> Require and strip u+x before execution to prevent sysupgrade(8) loop.

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-25 Thread Theo de Raadt
Klemens Nanni wrote: > Are there more reasons or benefits to this approach than a) less intrusive > chmod() and b) more shared, overall less code? > > I obviously don't see the full picture (yet). A normal bootloader only reads from disk. No write occur. The chmod hack is a write. In the li

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-25 Thread Klemens Nanni
On Mon, Sep 25, 2023 at 05:35:40AM +, Visa Hankala wrote: > On Sat, Sep 23, 2023 at 02:26:18PM +, Klemens Nanni wrote: > > On Sat, Sep 23, 2023 at 01:11:32PM +0200, Mark Kettenis wrote: > > > > Date: Thu, 21 Sep 2023 22:30:01 + > > > > From: Klemens Nanni > > > > > > > > In comparison

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-24 Thread Theo de Raadt
Visa Hankala wrote: > On Sat, Sep 23, 2023 at 02:26:18PM +, Klemens Nanni wrote: > > On Sat, Sep 23, 2023 at 01:11:32PM +0200, Mark Kettenis wrote: > > > > Date: Thu, 21 Sep 2023 22:30:01 + > > > > From: Klemens Nanni > > > > > > > > In comparison to MI boot which only cares about /bsd.

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-24 Thread Visa Hankala
On Sat, Sep 23, 2023 at 02:26:18PM +, Klemens Nanni wrote: > On Sat, Sep 23, 2023 at 01:11:32PM +0200, Mark Kettenis wrote: > > > Date: Thu, 21 Sep 2023 22:30:01 + > > > From: Klemens Nanni > > > > > > In comparison to MI boot which only cares about /bsd.upgrade's x bit, > > > powerpc64 r

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-23 Thread Klemens Nanni
On Sat, Sep 23, 2023 at 01:11:32PM +0200, Mark Kettenis wrote: > > Date: Thu, 21 Sep 2023 22:30:01 + > > From: Klemens Nanni > > > > In comparison to MI boot which only cares about /bsd.upgrade's x bit, > > powerpc64 rdboot just wants a regular file. > > > > Require and strip u+x before exec

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-23 Thread Mark Kettenis
> Date: Thu, 21 Sep 2023 22:30:01 + > From: Klemens Nanni > > In comparison to MI boot which only cares about /bsd.upgrade's x bit, > powerpc64 rdboot just wants a regular file. > > Require and strip u+x before execution to prevent sysupgrade(8) loop. > I'm new to powerpc64 and can't think o

prevent re-upgrade in powerpc64 boot loader

2023-09-21 Thread Klemens Nanni
In comparison to MI boot which only cares about /bsd.upgrade's x bit, powerpc64 rdboot just wants a regular file. Require and strip u+x before execution to prevent sysupgrade(8) loop. I'm new to powerpc64 and can't think of a reason to be different. Feedback? Objection? OK? Regular boot and sysu