Re: pool page colouring

2014-11-04 Thread Ted Unangst
On Tue, Oct 28, 2014 at 16:49, David Gwynne wrote: > when i shuffled the locking in pools around, page colouring was > left behind. > > page colouring is where you offset items within a page if you have > enough slack space. the previous implementation simply incremented > the colour so each new p

Re: pool page colouring

2014-11-04 Thread David Gwynne
> On 5 Nov 2014, at 10:58, Ted Unangst wrote: > > On Wed, Nov 05, 2014 at 09:38, David Gwynne wrote: >> >>> On 30 Oct 2014, at 07:52, Ted Unangst wrote: >>> >>> On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: >>> >>> i dunno. im fine with either removing colouring altogether or sett

Re: pool page colouring

2014-11-04 Thread Ted Unangst
On Wed, Nov 05, 2014 at 09:38, David Gwynne wrote: > >> On 30 Oct 2014, at 07:52, Ted Unangst wrote: >> >> On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: >> >> >>> i dunno. im fine with either removing colouring altogether or setting it >>> from something else completely. i just want a decisi

Re: pool page colouring

2014-11-04 Thread David Gwynne
> On 5 Nov 2014, at 10:27, David Gwynne wrote: > >> >> On 5 Nov 2014, at 10:12, Mike Belopuhov wrote: >> >> On 5 November 2014 00:38, David Gwynne wrote: >>> On 30 Oct 2014, at 07:52, Ted Unangst wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: > i

Re: pool page colouring

2014-11-04 Thread David Gwynne
> On 5 Nov 2014, at 10:12, Mike Belopuhov wrote: > > On 5 November 2014 00:38, David Gwynne wrote: >> >>> On 30 Oct 2014, at 07:52, Ted Unangst wrote: >>> >>> On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: >>> >>> i dunno. im fine with either removing colouring altogether or setti

Re: pool page colouring

2014-11-04 Thread Mike Belopuhov
On 5 November 2014 00:38, David Gwynne wrote: > >> On 30 Oct 2014, at 07:52, Ted Unangst wrote: >> >> On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: >> >> >>> i dunno. im fine with either removing colouring altogether or setting it >>> from something else completely. i just want a decision to

Re: pool page colouring

2014-11-04 Thread Mike Belopuhov
On 5 November 2014 01:12, Mike Belopuhov wrote: > > well, first of all, right now this is a rather theoretical gain. we > need to test it > to understand if it makes things easier. err. i meant to say go faster not easier.

Re: pool page colouring

2014-11-04 Thread David Gwynne
> On 30 Oct 2014, at 07:52, Ted Unangst wrote: > > On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: > > >> i dunno. im fine with either removing colouring altogether or setting it >> from something else completely. i just want a decision to be made cos >> right now ph_color isnt set, which i

Re: pool page colouring

2014-10-29 Thread Mike Belopuhov
On 29 October 2014 22:52, Ted Unangst wrote: > On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: > > >> i dunno. im fine with either removing colouring altogether or setting it >> from something else completely. i just want a decision to be made cos >> right now ph_color isnt set, which is a bug.

Re: pool page colouring

2014-10-29 Thread Ted Unangst
On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: > i dunno. im fine with either removing colouring altogether or setting it > from something else completely. i just want a decision to be made cos > right now ph_color isnt set, which is a bug. there. i fixed it. Index: kern/subr_pool.c ===

Re: pool page colouring

2014-10-29 Thread Mike Belopuhov
On 29 October 2014 16:48, Ted Unangst wrote: > On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: > >> if you want it to go fast, it would make more sense to set the item >> alignment in pool_init to the size of the cacheline. colouring would then >> become irrelevant from a speed perspective. > >

Re: pool page colouring

2014-10-29 Thread Ted Unangst
On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: > if you want it to go fast, it would make more sense to set the item > alignment in pool_init to the size of the cacheline. colouring would then > become irrelevant from a speed perspective. There's some sense to this. Like round everything to n

Re: pool page colouring

2014-10-28 Thread David Gwynne
> On 29 Oct 2014, at 2:44 am, Mike Belopuhov wrote: > > On 28 October 2014 17:02, Ted Unangst wrote: >> On Tue, Oct 28, 2014 at 16:49, David Gwynne wrote: >>> when i shuffled the locking in pools around, page colouring was >>> left behind. >>> >>> page colouring is where you offset items withi

Re: pool page colouring

2014-10-28 Thread Mike Belopuhov
On 28 October 2014 17:02, Ted Unangst wrote: > On Tue, Oct 28, 2014 at 16:49, David Gwynne wrote: >> when i shuffled the locking in pools around, page colouring was >> left behind. >> >> page colouring is where you offset items within a page if you have >> enough slack space. the previous implemen

Re: pool page colouring

2014-10-28 Thread Ted Unangst
On Tue, Oct 28, 2014 at 16:49, David Gwynne wrote: > when i shuffled the locking in pools around, page colouring was > left behind. > > page colouring is where you offset items within a page if you have > enough slack space. the previous implementation simply incremented > the colour so each new p

pool page colouring

2014-10-27 Thread David Gwynne
when i shuffled the locking in pools around, page colouring was left behind. page colouring is where you offset items within a page if you have enough slack space. the previous implementation simply incremented the colour so each new page got the next offset. i didnt do this because the page and i