Re: [External] : pfsync mutex mpfloor

2022-04-13 Thread Alexandr Nedvedicky
On Wed, Apr 13, 2022 at 09:33:52PM +0200, Alexander Bluhm wrote: > Hi, > > Hrvoje has hit a witness issue in pfsync. > > panic: acquiring blockable sleep lock with spinlock or critical > section held (kernel_lock) &kernel_lock > > panic(81f45bb7) at panic+0xbf > witness_checkorder(ff

pfsync mutex mpfloor

2022-04-13 Thread Alexander Bluhm
Hi, Hrvoje has hit a witness issue in pfsync. panic: acquiring blockable sleep lock with spinlock or critical section held (kernel_lock) &kernel_lock panic(81f45bb7) at panic+0xbf witness_checkorder(8246e970,9,0) at witness_checkorder+0xb61 __mp_lock(8246e768) at __mp_loc

Re: [External] : Re: pfsync mutex

2022-02-28 Thread Alexandr Nedvedicky
Hello, > > do you need ddb console ? if you want i can try to reproduce this panic > without isakmpd, just hitting pfsync setup? > > console might help. I won't be able to get to it before tonight/tomorrow. I think you can leave isakmpd enabled. it still might be a contributing

Re: [External] : Re: pfsync mutex

2022-02-28 Thread Hrvoje Popovski
On 28.2.2022. 10:49, Alexandr Nedvedicky wrote: > Hello, > > >>> i will still play with sasyncd setup, maybe something comes up >>> >> >> And when I thought everything is fine.. after 2 days of hitting sasyncd >> setup I've got this panic .. will stay in ddb if some other information >> is needed

Re: [External] : Re: pfsync mutex

2022-02-28 Thread Alexandr Nedvedicky
Hello, > > i will still play with sasyncd setup, maybe something comes up > > > > And when I thought everything is fine.. after 2 days of hitting sasyncd > setup I've got this panic .. will stay in ddb if some other information > is needed > I think you are hitting a different issue, whic

Re: pfsync mutex

2022-02-28 Thread Hrvoje Popovski
On 26.2.2022. 21:36, Hrvoje Popovski wrote: > On 25.2.2022. 23:22, Alexander Bluhm wrote: >> On Fri, Feb 25, 2022 at 10:21:50PM +0100, Hrvoje Popovski wrote: >>> On 24.2.2022. 22:42, Alexander Bluhm wrote: Hi, Hrvoje reported some crashes with pfsync, IPsec and parallel forwardi

Re: pfsync mutex

2022-02-26 Thread Hrvoje Popovski
On 25.2.2022. 23:22, Alexander Bluhm wrote: > On Fri, Feb 25, 2022 at 10:21:50PM +0100, Hrvoje Popovski wrote: >> On 24.2.2022. 22:42, Alexander Bluhm wrote: >>> Hi, >>> >>> Hrvoje reported some crashes with pfsync, IPsec and parallel >>> forwarding. Some locks were missing around the tdb flags in

Re: pfsync mutex

2022-02-25 Thread Alexander Bluhm
On Fri, Feb 25, 2022 at 10:21:50PM +0100, Hrvoje Popovski wrote: > On 24.2.2022. 22:42, Alexander Bluhm wrote: > > Hi, > > > > Hrvoje reported some crashes with pfsync, IPsec and parallel > > forwarding. Some locks were missing around the tdb flags in pfsync. > > before trying this diff i wanted

Re: pfsync mutex

2022-02-25 Thread Hrvoje Popovski
On 24.2.2022. 22:42, Alexander Bluhm wrote: > Hi, > > Hrvoje reported some crashes with pfsync, IPsec and parallel > forwarding. Some locks were missing around the tdb flags in pfsync. before trying this diff i wanted to see if i could still trigger panic with sasyncd setup and parallel forwardi

Re: [External] : pfsync mutex

2022-02-24 Thread Alexandr Nedvedicky
Hello, On Thu, Feb 24, 2022 at 10:42:58PM +0100, Alexander Bluhm wrote: > Hi, > > Hrvoje reported some crashes with pfsync, IPsec and parallel > forwarding. Some locks were missing around the tdb flags in pfsync. > > ok? > change looks good to me. I just have a single concern about pf

pfsync mutex

2022-02-24 Thread Alexander Bluhm
Hi, Hrvoje reported some crashes with pfsync, IPsec and parallel forwarding. Some locks were missing around the tdb flags in pfsync. ok? bluhm Index: net/if_pfsync.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/if_pfsync.c,v