Re: pfsync debug bye-bye

2022-04-20 Thread David Gwynne
> On 21 Apr 2022, at 02:14, Alexander Bluhm wrote: > > Hi, > > In pfsync there are some KASSERT hidden behind #ifdef PFSYNC_DEBUG. > That does not make sense to me. Either they are correct, then they > should actively check in production. Or they got wrong over time, > then they should not

Re: [External] : pfsync debug bye-bye

2022-04-20 Thread Alexandr Nedvedicky
Hello, On Wed, Apr 20, 2022 at 06:14:37PM +0200, Alexander Bluhm wrote: > Hi, > > In pfsync there are some KASSERT hidden behind #ifdef PFSYNC_DEBUG. > That does not make sense to me. Either they are correct, then they > should actively check in production. Or they got wrong over time, > then t

pfsync debug bye-bye

2022-04-20 Thread Alexander Bluhm
Hi, In pfsync there are some KASSERT hidden behind #ifdef PFSYNC_DEBUG. That does not make sense to me. Either they are correct, then they should actively check in production. Or they got wrong over time, then they should not make debugging harder. Some basic testing did not show problems. ok?