Re: pflow(4) percpu counters

2017-02-21 Thread Jeremie Courreges-Anglas
Jeremie Courreges-Anglas writes: > Florian Obser writes: > >> On Sat, Feb 18, 2017 at 06:06:01PM +0100, Jeremie Courreges-Anglas wrote: >>> >>> This one is a bit weird, the driver doesn't just increment the stats but >>> also uses them at runtime, hence the additional helper functions. >> >> I'

Re: pflow(4) percpu counters

2017-02-20 Thread Jeremie Courreges-Anglas
Florian Obser writes: > On Sat, Feb 18, 2017 at 06:06:01PM +0100, Jeremie Courreges-Anglas wrote: >> >> This one is a bit weird, the driver doesn't just increment the stats but >> also uses them at runtime, hence the additional helper functions. > > I'm wondering if we should just drop the readi

Re: pflow(4) percpu counters

2017-02-20 Thread Florian Obser
On Sat, Feb 18, 2017 at 06:06:01PM +0100, Jeremie Courreges-Anglas wrote: > > This one is a bit weird, the driver doesn't just increment the stats but > also uses them at runtime, hence the additional helper functions. I'm wondering if we should just drop the reading. We have two cases, the init

pflow(4) percpu counters

2017-02-18 Thread Jeremie Courreges-Anglas
This one is a bit weird, the driver doesn't just increment the stats but also uses them at runtime, hence the additional helper functions. ok? Index: net/if_pflow.h === RCS file: /d/cvs/src/sys/net/if_pflow.h,v retrieving revision