Re: [External] : pfioctl goto fail

2022-03-23 Thread Alexandr Nedvedicky
On Wed, Mar 23, 2022 at 03:53:21PM +0100, Alexander Bluhm wrote: > Hi, > > pfioctl() is inconsistent when to use break or goto fail. There > is a big switch and when looking at a break you need more context > to see where it jumps to. > > I would like to use goto fail consistently to leave the b

Re: pfioctl goto fail

2022-03-23 Thread Todd C . Miller
On Wed, 23 Mar 2022 15:53:21 +0100, Alexander Bluhm wrote: > Hi, > is a big switch and when looking at a break you need more context > to see where it jumps to. > > I would like to use goto fail consistently to leave the big switch. > break is used for inner switches and loops. This makes it easi

pfioctl goto fail

2022-03-23 Thread Alexander Bluhm
Hi, pfioctl() is inconsistent when to use break or goto fail. There is a big switch and when looking at a break you need more context to see where it jumps to. I would like to use goto fail consistently to leave the big switch. break is used for inner switches and loops. No binary diff. ok? b